diff mbox series

[v2] tty: serial: samsung_tty: support 18 uart ports

Message ID 20250404135006.1263827-1-faraz.ata@samsung.com
State New
Headers show
Series [v2] tty: serial: samsung_tty: support 18 uart ports | expand

Commit Message

Faraz Ata April 4, 2025, 1:50 p.m. UTC 
Exynos Auto v920 SoC supports up to 18 UART ports.
Hence changing the value of UART_NR to 18.
---
 drivers/tty/serial/samsung_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Faraz Ata April 11, 2025, 6:23 a.m. UTC | #1 
Hello Krzysztof

> Subject: Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports
> 
> On 04/04/2025 15:50, Faraz Ata wrote:
> > Exynos Auto v920 SoC supports up to 18 UART ports.
> > Hence changing the value of UART_NR to 18.
> > ---
> 
> How v2, without changelog, is even worse than v1? It goes to wrong
> direction.
> 
> Please run scripts/checkpatch.pl and fix reported warnings. After that, run
> also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some
> warnings can be ignored, especially from --strict run, but the code here looks
> like it needs a fix. Feel free to get in touch if the warning is not clear.
> 
>
Thanks for your review and sorry for the noise,
 that was not intentional, got posted by mistake, will takecare about it.
Will send another version with change-log.
> ...
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 210fff7164c1..9a5211b730fb 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -52,7 +52,7 @@ 
 #define S3C24XX_SERIAL_MINOR	64
 
 #ifdef CONFIG_ARM64
-#define UART_NR			12
+#define UART_NR			18
 #else
 #define UART_NR			CONFIG_SERIAL_SAMSUNG_UARTS
 #endif