Message ID | 20250411213601.3273670-1-Frank.Li@nxp.com |
---|---|
State | New |
Headers | show |
Series | [1/1] dt-bindings: media: convert fsl-vdoa.txt to yaml format | expand |
On Fri, 11 Apr 2025 17:36:00 -0400, Frank Li wrote: > Convert fsl-vdoa.txt to yaml format. > > Additional changes: > - Add irq.h and imx6qdl-clock.h in example. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/media/fsl,imx6q-vdoa.yaml | 42 +++++++++++++++++++ > .../devicetree/bindings/media/fsl-vdoa.txt | 21 ---------- > 2 files changed, 42 insertions(+), 21 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml > delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Hi again, Le jeudi 22 mai 2025 à 14:57 -0400, Nicolas Dufresne a écrit : > Hi Frank, > > Le jeudi 22 mai 2025 à 14:49 -0400, Frank Li a écrit : > > On Sat, Apr 12, 2025 at 01:04:14PM -0500, Rob Herring (Arm) wrote: > > > > > > On Fri, 11 Apr 2025 17:36:00 -0400, Frank Li wrote: > > > > Convert fsl-vdoa.txt to yaml format. > > > > > > > > Additional changes: > > > > - Add irq.h and imx6qdl-clock.h in example. > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > .../bindings/media/fsl,imx6q-vdoa.yaml | 42 +++++++++++++++++++ > > > > .../devicetree/bindings/media/fsl-vdoa.txt | 21 ---------- > > > > 2 files changed, 42 insertions(+), 21 deletions(-) > > > > create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml > > > > delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt > > > > > > > > > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > > > > All: > > Anyone pick this patch? > > Thanks for the highlight, this is stuff from before my time and I had not associated it > with CODA initially. I've picked it now. Actually, before I do so, any of the following warnings should be addressed ? I effectively don't see a clear entry for that bindings, but could have miss-read and there is a second warning, which based on having Rb is likely false positive ? --- [[ATTACHMENT|junit/./0001-dt-bindings-media-convert-fsl-vdoa.txt-to-yaml-forma.patch checkpatch.err.txt]] WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting- patches.rst total: 0 errors, 2 warnings, 0 checks, 42 lines checked --- Nicolas > > regards, > Nicolas > > > > > Frank > > >
diff --git a/Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml b/Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml new file mode 100644 index 0000000000000..511ac0d67a7f2 --- /dev/null +++ b/Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/fsl,imx6q-vdoa.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Video Data Order Adapter + +description: + The Video Data Order Adapter (VDOA) is present on the i.MX6q. Its sole purpose + is to reorder video data from the macroblock tiled order produced by the CODA + 960 VPU to the conventional raster-scan order for scanout. + +maintainers: + - Frank Li <Frank.Li@nxp.com> + +properties: + compatible: + const: "fsl,imx6q-vdoa" + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/clock/imx6qdl-clock.h> + + vdoa@21e4000 { + compatible = "fsl,imx6q-vdoa"; + reg = <0x021e4000 0x4000>; + interrupts = <0 18 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX6QDL_CLK_VDOA>; + }; diff --git a/Documentation/devicetree/bindings/media/fsl-vdoa.txt b/Documentation/devicetree/bindings/media/fsl-vdoa.txt deleted file mode 100644 index 6c5628530bb7b..0000000000000 --- a/Documentation/devicetree/bindings/media/fsl-vdoa.txt +++ /dev/null @@ -1,21 +0,0 @@ -Freescale Video Data Order Adapter -================================== - -The Video Data Order Adapter (VDOA) is present on the i.MX6q. Its sole purpose -is to reorder video data from the macroblock tiled order produced by the CODA -960 VPU to the conventional raster-scan order for scanout. - -Required properties: -- compatible: must be "fsl,imx6q-vdoa" -- reg: the register base and size for the device registers -- interrupts: the VDOA interrupt -- clocks: the vdoa clock - -Example: - -vdoa@21e4000 { - compatible = "fsl,imx6q-vdoa"; - reg = <0x021e4000 0x4000>; - interrupts = <0 18 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_VDOA>; -};
Convert fsl-vdoa.txt to yaml format. Additional changes: - Add irq.h and imx6qdl-clock.h in example. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../bindings/media/fsl,imx6q-vdoa.yaml | 42 +++++++++++++++++++ .../devicetree/bindings/media/fsl-vdoa.txt | 21 ---------- 2 files changed, 42 insertions(+), 21 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/fsl,imx6q-vdoa.yaml delete mode 100644 Documentation/devicetree/bindings/media/fsl-vdoa.txt