| Message ID | 1337335608-6901-3-git-send-email-feng.wei@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Fri, 2012-05-18 at 18:06 +0800, feng.wei@linaro.org wrote: > From: Feng Wei <feng.wei@linaro.org> > > Make UCM branches available in alsa module when alsa card detected. > > Signed-off-by: Feng Wei <feng.wei@linaro.org> > --- > src/modules/module-udev-detect.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c > index 1192194..ccc3374 100644 > --- a/src/modules/module-udev-detect.c > +++ b/src/modules/module-udev-detect.c > @@ -394,6 +394,7 @@ static void card_changed(struct userdata *u, struct udev_device *dev) { > "fixed_latency_range=%s " > "ignore_dB=%s " > "deferred_volume=%s " > + "use_ucm=1 " > "card_properties=\"module-udev-detect.discovered=1\"", > path_get_card_id(path), > n, Do we really need this? We could just have it on-by-default in module-alsa-card, where you already gracefully fallback to the old behaviour of UCM configs don't exist. -- Arun
2012/6/8 Arun Raghavan <arun.raghavan@collabora.co.uk>: > On Fri, 2012-05-18 at 18:06 +0800, feng.wei@linaro.org wrote: >> From: Feng Wei <feng.wei@linaro.org> >> >> Make UCM branches available in alsa module when alsa card detected. >> >> Signed-off-by: Feng Wei <feng.wei@linaro.org> >> --- >> src/modules/module-udev-detect.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c >> index 1192194..ccc3374 100644 >> --- a/src/modules/module-udev-detect.c >> +++ b/src/modules/module-udev-detect.c >> @@ -394,6 +394,7 @@ static void card_changed(struct userdata *u, struct udev_device *dev) { >> "fixed_latency_range=%s " >> "ignore_dB=%s " >> "deferred_volume=%s " >> + "use_ucm=1 " >> "card_properties=\"module-udev-detect.discovered=1\"", >> path_get_card_id(path), >> n, > > Do we really need this? We could just have it on-by-default in > module-alsa-card, where you already gracefully fallback to the old > behaviour of UCM configs don't exist. I'm happy to remove that if the fallback really work well. I didn't have enough test. Your words gave me more confidence. :-) > > -- Arun > > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
diff --git a/src/modules/module-udev-detect.c b/src/modules/module-udev-detect.c index 1192194..ccc3374 100644 --- a/src/modules/module-udev-detect.c +++ b/src/modules/module-udev-detect.c @@ -394,6 +394,7 @@ static void card_changed(struct userdata *u, struct udev_device *dev) { "fixed_latency_range=%s " "ignore_dB=%s " "deferred_volume=%s " + "use_ucm=1 " "card_properties=\"module-udev-detect.discovered=1\"", path_get_card_id(path), n,