| Message ID | 20250424131201.157601-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: mediatek: Fix sizeof argument pctl->eint->base | expand |
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 8596f3541265..4c2b72a3543a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -1017,7 +1017,7 @@ static int mtk_eint_init(struct mtk_pinctrl *pctl, struct platform_device *pdev) pctl->eint->nbase = 1; /* mtk-eint expects an array */ - pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(pctl->eint->base), GFP_KERNEL); + pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(*pctl->eint->base), GFP_KERNEL); if (!pctl->eint->base) return -ENOMEM;
The sizeof argument is incorrect when allocating pctl->eint->base, it should be *pctl->eint->base. (Generally, the size of void * is the same as void ** so nothing is breaking in this specific case). Fix this. Fixes: fe412e3a6c97 ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)