diff mbox series

x86/microcode/AMD: Use sha256() instead of init/update/final

Message ID 20250428183006.782501-1-ebiggers@kernel.org
State New
Headers show
Series x86/microcode/AMD: Use sha256() instead of init/update/final | expand

Commit Message

Eric Biggers April 28, 2025, 6:30 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

Just call sha256() instead of doing the init/update/final sequence.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---

This patch is targeting the x86 tree.

 arch/x86/kernel/cpu/microcode/amd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)


base-commit: 33035b665157558254b3c21c3f049fd728e72368
diff mbox series

Patch

diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
index 1798a6c027f89..f1fae6e282215 100644
--- a/arch/x86/kernel/cpu/microcode/amd.c
+++ b/arch/x86/kernel/cpu/microcode/amd.c
@@ -215,11 +215,10 @@  static bool need_sha_check(u32 cur_rev)
 
 static bool verify_sha256_digest(u32 patch_id, u32 cur_rev, const u8 *data, unsigned int len)
 {
 	struct patch_digest *pd = NULL;
 	u8 digest[SHA256_DIGEST_SIZE];
-	struct sha256_state s;
 	int i;
 
 	if (x86_family(bsp_cpuid_1_eax) < 0x17)
 		return true;
 
@@ -233,13 +232,11 @@  static bool verify_sha256_digest(u32 patch_id, u32 cur_rev, const u8 *data, unsi
 	if (!pd) {
 		pr_err("No sha256 digest for patch ID: 0x%x found\n", patch_id);
 		return false;
 	}
 
-	sha256_init(&s);
-	sha256_update(&s, data, len);
-	sha256_final(&s, digest);
+	sha256(data, len, digest);
 
 	if (memcmp(digest, pd->sha256, sizeof(digest))) {
 		pr_err("Patch 0x%x SHA256 digest mismatch!\n", patch_id);
 
 		for (i = 0; i < SHA256_DIGEST_SIZE; i++)