| Message ID | 20250428180256.1482899-1-tjmercier@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/bpf: Fix kmem_cache iterator draining | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Mon, 28 Apr 2025 18:02:54 +0000 you wrote: > The closing parentheses around the read syscall is misplaced, causing > single byte reads from the iterator instead of buf sized reads. While > the end result is the same, many more read calls than necessary are > performed. > > $ tools/testing/selftests/bpf/vmtest.sh "./test_progs -t kmem_cache_iter" > 145/1 kmem_cache_iter/check_task_struct:OK > 145/2 kmem_cache_iter/check_slabinfo:OK > 145/3 kmem_cache_iter/open_coded_iter:OK > 145 kmem_cache_iter:OK > Summary: 1/3 PASSED, 0 SKIPPED, 0 FAILED > > [...] Here is the summary with links: - selftests/bpf: Fix kmem_cache iterator draining https://git.kernel.org/bpf/bpf-next/c/38d976c32d85 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c b/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c index 8e13a3416a21..1de14b111931 100644 --- a/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c +++ b/tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c @@ -104,7 +104,7 @@ void test_kmem_cache_iter(void) goto destroy; memset(buf, 0, sizeof(buf)); - while (read(iter_fd, buf, sizeof(buf) > 0)) { + while (read(iter_fd, buf, sizeof(buf)) > 0) { /* Read out all contents */ printf("%s", buf); }
The closing parentheses around the read syscall is misplaced, causing single byte reads from the iterator instead of buf sized reads. While the end result is the same, many more read calls than necessary are performed. $ tools/testing/selftests/bpf/vmtest.sh "./test_progs -t kmem_cache_iter" 145/1 kmem_cache_iter/check_task_struct:OK 145/2 kmem_cache_iter/check_slabinfo:OK 145/3 kmem_cache_iter/open_coded_iter:OK 145 kmem_cache_iter:OK Summary: 1/3 PASSED, 0 SKIPPED, 0 FAILED Fixes: a496d0cdc84d ("selftests/bpf: Add a test for kmem_cache_iter") Signed-off-by: T.J. Mercier <tjmercier@google.com> --- tools/testing/selftests/bpf/prog_tests/kmem_cache_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: b4432656b36e5cc1d50a1f2dc15357543add530e