diff mbox series

[BlueZ,v1] device: Fix not setting DEVICE_FLAG_REMOTE_WAKEUP when required

Message ID 20250429163615.2188056-1-luiz.dentz@gmail.com
State New
Headers show
Series [BlueZ,v1] device: Fix not setting DEVICE_FLAG_REMOTE_WAKEUP when required | expand

Commit Message

Luiz Augusto von Dentz April 29, 2025, 4:36 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Due to the introduction of DEVICE_FLAG_ADDRESS_RESOLUTION it is no
longer possible to check if the kernel has support for it ahead of time
since that would depend on device->supported_flags which is only updated
with MGMT_OP_ADD_DEVICE _after_ services are probed.

Fixes: https://github.com/bluez/bluez/issues/1207
---
 src/device.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

bluez.test.bot@gmail.com April 29, 2025, 6:06 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=958207

---Test result---

Test Summary:
CheckPatch                    PENDING   0.29 seconds
GitLint                       PENDING   0.22 seconds
BuildEll                      PASS      20.41 seconds
BluezMake                     PASS      2624.79 seconds
MakeCheck                     PASS      20.41 seconds
MakeDistcheck                 PASS      199.32 seconds
CheckValgrind                 PASS      275.36 seconds
CheckSmatch                   PASS      305.42 seconds
bluezmakeextell               PASS      129.34 seconds
IncrementalBuild              PENDING   0.25 seconds
ScanBuild                     PASS      919.31 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org April 30, 2025, 1:40 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 29 Apr 2025 12:36:15 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Due to the introduction of DEVICE_FLAG_ADDRESS_RESOLUTION it is no
> longer possible to check if the kernel has support for it ahead of time
> since that would depend on device->supported_flags which is only updated
> with MGMT_OP_ADD_DEVICE _after_ services are probed.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] device: Fix not setting DEVICE_FLAG_REMOTE_WAKEUP when required
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=570a5505fc79

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/device.c b/src/device.c
index 2ee319c4f7c2..c364d72c3bdf 100644
--- a/src/device.c
+++ b/src/device.c
@@ -1552,12 +1552,6 @@  static bool device_get_wake_support(struct btd_device *device)
 
 void device_set_wake_support(struct btd_device *device, bool wake_support)
 {
-	if (device->rpa && !btd_adapter_has_exp_feature(device->adapter,
-						EXP_FEAT_RPA_RESOLUTION)) {
-		warn("Unable to set wake_support without RPA resolution");
-		return;
-	}
-
 	device->wake_support = wake_support;
 
 	if (device->wake_support)