| Message ID | 20250507020718.7446-1-wkon.kim@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ufs: core: Print error value as hex format on ufshcd_err_handler() | expand |
> On 5/6/25 7:07 PM, wkon-kim wrote: > > It is better to print saved_err and saved_uic_err in hex format. > > Integer format is hard to spot. > > spot -> decode > > Anyway: > > Reviewed-by: Bart Van Assche <bvanassche@acm.org> Okay, I'll modify it. Thank you. Wonkon Kim
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 5cb6132b8147..eb0ce35a7a9c 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -6572,7 +6572,7 @@ static void ufshcd_err_handler(struct work_struct *work) hba = container_of(work, struct ufs_hba, eh_work); dev_info(hba->dev, - "%s started; HBA state %s; powered %d; shutting down %d; saved_err = %d; saved_uic_err = %d; force_reset = %d%s\n", + "%s started; HBA state %s; powered %d; shutting down %d; saved_err = 0x%x; saved_uic_err = 0x%x; force_reset = %d%s\n", __func__, ufshcd_state_name[hba->ufshcd_state], hba->is_powered, hba->shutting_down, hba->saved_err, hba->saved_uic_err, hba->force_reset,
It is better to print saved_err and saved_uic_err in hex format. Integer format is hard to spot. [ 1024.485428] [2: kworker/u20:13:28211] exynos-ufs 17100000.ufs: ufshcd_err_handler started; HBA state eh_fatal; powered 1; shutting down 0; saved_err = 131072; saved_uic_err = 0; force_reset = 0; link is broken Signed-off-by: Wonkon Kim <wkon.kim@samsung.com> --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)