i.MX8 ISI crossbar: simplify a couple of error messages

I guess these messages were split from a single function. Or was it
for saving memory? :-)

Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>

Hi Krzysztof,

On Fri, May 09, 2025 at 09:58:09AM +0200, Krzysztof Hałasa wrote:
> I guess these messages were split from a single function. Or was it
> for saving memory? :-)

The goal was indeed to save memory.

> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index 93a55c97cd17..b6c7f114f9ed 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd,
>  						 sink_streams);
>  		if (ret) {
>  			dev_err(xbar->isi->dev,
> -				"failed to %s streams 0x%llx on '%s':%u: %d\n",
> -				"enable", sink_streams, remote_sd->name,
> -				remote_pad, ret);
> +				"failed to enable streams 0x%llx on '%s':%u: %d\n",
> +				sink_streams, remote_sd->name, remote_pad, ret);
>  			mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
>  			return ret;
>  		}
> @@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd,
>  						  sink_streams);
>  		if (ret)
>  			dev_err(xbar->isi->dev,
> -				"failed to %s streams 0x%llx on '%s':%u: %d\n",
> -				"disable", sink_streams, remote_sd->name,
> -				remote_pad, ret);
> +				"failed to disable streams 0x%llx on '%s':%u: %d\n",
> +				sink_streams, remote_sd->name, remote_pad, ret);
>  
>  		mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
>  	}

Hi Laurent,

Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

> The goal was indeed to save memory.
>
>> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
>> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
>> @@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd,
>>                                                sink_streams);
>>               if (ret) {
>>                       dev_err(xbar->isi->dev,
>> -                             "failed to %s streams 0x%llx on '%s':%u: %d\n",
>> -                             "enable", sink_streams, remote_sd->name,
>> -                             remote_pad, ret);
>> +                             "failed to enable streams 0x%llx on '%s':%u: %d\n",
>> +                             sink_streams, remote_sd->name, remote_pad, ret);
>>                       mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
>>                       return ret;
>>               }
>> @@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd,
>>                                                 sink_streams);
>>               if (ret)
>>                       dev_err(xbar->isi->dev,
>> -                             "failed to %s streams 0x%llx on '%s':%u: %d\n",
>> -                             "disable", sink_streams, remote_sd->name,
>> -                             remote_pad, ret);
>> +                             "failed to disable streams 0x%llx on '%s':%u: %d\n",
>> +                             sink_streams, remote_sd->name, remote_pad, ret);

It appears the current code saves (in my default build) 8 bytes of
memory, at the cost of readability and inability to search with grep:

Current:
Name          Size      File off
.text         00000bf4  00000040
.data         00000000  00000c34
.rodata.str1.8 000001b8 00000c38
__jump_table  00000030  00000df0
.rodata       000001b8  00000e20

With patch:
Name          Size      File off
.text         00000bd4  00000040
.data         00000000  00000c14
.rodata.str1.8 000001e0 00000c18
__jump_table  00000030  00000df8
.rodata       000001b8  00000e28

Built as a module it doesn't even save that - the number of pages stays
the same.

Just FYI.