diff mbox series

crypto: qat - add missing header inclusion

Message ID 20250520161148.3562622-1-arnd@kernel.org
State New
Headers show
Series crypto: qat - add missing header inclusion | expand

Commit Message

Arnd Bergmann May 20, 2025, 4:11 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

Without this header, building the new driver fails with:

In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
   13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~

Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
 drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
 2 files changed, 2 insertions(+)

Comments

Herbert Xu May 23, 2025, 11:27 a.m. UTC | #1
On Thu, May 22, 2025 at 11:21:41AM +0100, Cabiddu, Giovanni wrote:
>
> Without this header, the build of the new qat_6xxx driver fails when
> CONFIG_PCI_IOV is not set:
> 
>     In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
>     drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
>     drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
>        13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
>           |                                  ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
>  drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
>  2 files changed, 2 insertions(+)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
index a716545a764c..9efee0053f3a 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h
@@ -4,6 +4,7 @@ 
 #define ADF_GEN2_PFVF_H
 
 #include <linux/types.h>
+#include "adf_common_drv.h"
 #include "adf_accel_devices.h"
 
 #define ADF_GEN2_ERRSOU3 (0x3A000 + 0x0C)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
index 17d1b774d4a8..2c8708117f70 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h
@@ -4,6 +4,7 @@ 
 #define ADF_GEN4_PFVF_H
 
 #include "adf_accel_devices.h"
+#include "adf_common_drv.h"
 
 #ifdef CONFIG_PCI_IOV
 void adf_gen4_init_pf_pfvf_ops(struct adf_pfvf_ops *pfvf_ops);