diff mbox series

[v4,14/15] qapi/misc-i386: s/field will be set/field is set/

Message ID 20250522190542.588267-15-pierrick.bouvier@linaro.org
State New
Headers show
Series qapi: remove all TARGET_* conditionals from the schema | expand

Commit Message

Pierrick Bouvier May 22, 2025, 7:05 p.m. UTC
As requested by Markus:
> I'd prefer "field is set".

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 qapi/misc-i386.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster May 27, 2025, 11:17 a.m. UTC | #1
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> As requested by Markus:
>> I'd prefer "field is set".
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>  qapi/misc-i386.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
> index 3fda7a20bdd..6f79817e382 100644
> --- a/qapi/misc-i386.json
> +++ b/qapi/misc-i386.json
> @@ -129,7 +129,7 @@
>  # Return information about SEV/SEV-ES/SEV-SNP.
>  #
>  # If unavailable due to an incompatible configuration the
> -# returned @enabled field will be set to 'false' and the
> +# returned @enabled field is set to 'false' and the
>  # state of all other fields is undefined.
>  #
>  # Returns: @SevInfo

I'd squash this into PATCH 02.  I figure you didn't because PATCH 02 is
Daniel's.  Here's how I would record provenance when squashing:

    Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
    Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
    [Doc comment tweaked]
    Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

If you want to blame me for the tweak (kidding, it's fine), you could
use [Doc comment tweaked at Markus's request].
diff mbox series

Patch

diff --git a/qapi/misc-i386.json b/qapi/misc-i386.json
index 3fda7a20bdd..6f79817e382 100644
--- a/qapi/misc-i386.json
+++ b/qapi/misc-i386.json
@@ -129,7 +129,7 @@ 
 # Return information about SEV/SEV-ES/SEV-SNP.
 #
 # If unavailable due to an incompatible configuration the
-# returned @enabled field will be set to 'false' and the
+# returned @enabled field is set to 'false' and the
 # state of all other fields is undefined.
 #
 # Returns: @SevInfo