| Message ID | 20250523134025.75130-10-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | pmdomain: Add generic ->sync_state() support to genpd | expand |
Hi Konrad, On Fri, 23 May 2025 at 21:42, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote: > > On 5/23/25 3:40 PM, Ulf Hansson wrote: > > To make sure genpd tries to power off unused PM domains, let's call > > of_genpd_sync_state() from our own ->sync_state() callback. > > > > Cc: Bjorn Andersson <andersson@kernel.org> > > Cc: Konrad Dybcio <konradybcio@kernel.org> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > --- > > note: the subject is wrong - this driver is rpmpd, the other > one is rpm*h*pd (patch 10 has the correct subject) Thanks for spotting this! BTW, would it be possible for you to run some tests on QC HW for this? Any help would be greatly appreciated. Kind regards Uffe
diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c index 0be6b3026e3a..833c46944600 100644 --- a/drivers/pmdomain/qcom/rpmpd.c +++ b/drivers/pmdomain/qcom/rpmpd.c @@ -1144,6 +1144,8 @@ static void rpmpd_sync_state(struct device *dev) unsigned int i; int ret; + of_genpd_sync_state(dev->of_node); + mutex_lock(&rpmpd_lock); for (i = 0; i < desc->num_pds; i++) { pd = rpmpds[i];
To make sure genpd tries to power off unused PM domains, let's call of_genpd_sync_state() from our own ->sync_state() callback. Cc: Bjorn Andersson <andersson@kernel.org> Cc: Konrad Dybcio <konradybcio@kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/pmdomain/qcom/rpmpd.c | 2 ++ 1 file changed, 2 insertions(+)