diff mbox series

[2/3] hw/ppc: PowerNV machines expose a I2C bus

Message ID 20250526112346.48744-3-philmd@linaro.org
State New
Headers show
Series hw/ppc: Fix --without-default-devices build | expand

Commit Message

Philippe Mathieu-Daudé May 26, 2025, 11:23 a.m. UTC 
Since commit 263b81ee15a, PowerNV machines instanciate
a I2C controller, so expose a I2C bus. Express that in
Kconfig, otherwise we get a configure error when trying
to use '--without-default-devices':

  The following clauses were found for PCA9552
      config PCA9552 depends on I2C
      select PCA9552 if POWERNV

Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/ppc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth May 26, 2025, 11:34 a.m. UTC | #1 
On 26/05/2025 13.23, Philippe Mathieu-Daudé wrote:
> Since commit 263b81ee15a, PowerNV machines instanciate
> a I2C controller, so expose a I2C bus. Express that in
> Kconfig, otherwise we get a configure error when trying
> to use '--without-default-devices':
> 
>    The following clauses were found for PCA9552
>        config PCA9552 depends on I2C
>        select PCA9552 if POWERNV
> 
> Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index ced6bbc7404..0d017df83ee 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -29,6 +29,7 @@ config POWERNV
>       depends on PPC64 && FDT
>       imply PCI_DEVICES
>       imply TEST_DEVICES
> +    select I2C
>       select ISA_IPMI_BT
>       select IPMI_LOCAL
>       select ISA_BUS

Reviewed-by: Thomas Huth <thuth@redhat.com>
Cédric Le Goater May 26, 2025, 11:48 a.m. UTC | #2 
On 5/26/25 13:23, Philippe Mathieu-Daudé wrote:
> Since commit 263b81ee15a, PowerNV machines instanciate
> a I2C controller, so expose a I2C bus. Express that in
> Kconfig, otherwise we get a configure error when trying
> to use '--without-default-devices':
> 
>    The following clauses were found for PCA9552
>        config PCA9552 depends on I2C
>        select PCA9552 if POWERNV
> 
> Fixes: 263b81ee15a ("ppc/pnv: Add an I2C controller model")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/ppc/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
> index ced6bbc7404..0d017df83ee 100644
> --- a/hw/ppc/Kconfig
> +++ b/hw/ppc/Kconfig
> @@ -29,6 +29,7 @@ config POWERNV
>       depends on PPC64 && FDT
>       imply PCI_DEVICES
>       imply TEST_DEVICES
> +    select I2C
>       select ISA_IPMI_BT
>       select IPMI_LOCAL
>       select ISA_BUS



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.
diff mbox series

Patch

diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index ced6bbc7404..0d017df83ee 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -29,6 +29,7 @@  config POWERNV
     depends on PPC64 && FDT
     imply PCI_DEVICES
     imply TEST_DEVICES
+    select I2C
     select ISA_IPMI_BT
     select IPMI_LOCAL
     select ISA_BUS