| Message ID | 20250525190020.27286-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4e221e2b5ee067960c128b91ac417a362934c842 |
| Headers | show |
| Series | Bluetooth: btnxpuart: Fix missing devm_request_irq() return value check | expand |
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sun, 25 May 2025 21:00:21 +0200 you wrote: > Return value of devm_request_irq() must be checked (function is even > annotated) and without it clang W=1 complains: > > btnxpuart.c:494:6: error: unused variable 'ret' [-Werror,-Wunused-variable] > > Setting up wakeup IRQ handler is not really critical, because the > handler is empty, so just log the informational message so user could > submit proper bug report and silences the clang warning. > > [...] Here is the summary with links: - Bluetooth: btnxpuart: Fix missing devm_request_irq() return value check https://git.kernel.org/bluetooth/bluetooth-next/c/4e221e2b5ee0 You are awesome, thank you!
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index b34623a69b8a..6b13feed06df 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -533,6 +533,8 @@ static int ps_setup(struct hci_dev *hdev) ps_host_wakeup_irq_handler, IRQF_ONESHOT | IRQF_TRIGGER_FALLING, dev_name(&serdev->dev), nxpdev); + if (ret) + bt_dev_info(hdev, "error setting wakeup IRQ handler, ignoring\n"); disable_irq(psdata->irq_handler); device_init_wakeup(&serdev->dev, true); }
Return value of devm_request_irq() must be checked (function is even annotated) and without it clang W=1 complains: btnxpuart.c:494:6: error: unused variable 'ret' [-Werror,-Wunused-variable] Setting up wakeup IRQ handler is not really critical, because the handler is empty, so just log the informational message so user could submit proper bug report and silences the clang warning. Fixes: c50b56664e48 ("Bluetooth: btnxpuart: Implement host-wakeup feature") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/bluetooth/btnxpuart.c | 2 ++ 1 file changed, 2 insertions(+)