diff mbox series

tests/functional/test_aarch64_hotplug_pci: Update images

Message ID 20250528014737.1630668-1-gustavo.romero@linaro.org
State New
Headers show
Series tests/functional/test_aarch64_hotplug_pci: Update images | expand

Commit Message

Gustavo Romero May 28, 2025, 1:47 a.m. UTC
The current links for the Linux and initrd.gz images are not truly
immutable, so let's change them to point to immutable versions, to avoid
having to keep updating their SHAs.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
---
 tests/functional/test_aarch64_hotplug_pci.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Huth May 28, 2025, 7:57 a.m. UTC | #1
On 28/05/2025 03.47, Gustavo Romero wrote:
> The current links for the Linux and initrd.gz images are not truly
> immutable, so let's change them to point to immutable versions, to avoid
> having to keep updating their SHAs.
> 
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   tests/functional/test_aarch64_hotplug_pci.py | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/functional/test_aarch64_hotplug_pci.py b/tests/functional/test_aarch64_hotplug_pci.py
> index fa1bb62c8f..2cf5c28b9f 100755
> --- a/tests/functional/test_aarch64_hotplug_pci.py
> +++ b/tests/functional/test_aarch64_hotplug_pci.py
> @@ -19,13 +19,13 @@ class HotplugPCI(LinuxKernelTest):
>   
>       ASSET_KERNEL = Asset(
>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
> -         'current/images/netboot/debian-installer/arm64/linux'),
> -        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/linux'),
> +         'd92a60392ce1e379ca198a1a820899f8f0d39a62d047c41ab79492f81541a9d9')
>   
>       ASSET_INITRD = Asset(
>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
> -         'current/images/netboot/debian-installer/arm64/initrd.gz'),
> -        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/initrd.gz'),
> +         '9f817f76951f3237bca8216bee35267bfb826815687f4b2fcdd5e6c2a917790c')
>   
>       def test_hotplug_pci(self):
>   

Acked-by: Thomas Huth <thuth@redhat.com>

Since the original patch is still sitting in Alex' queue, I assume that 
he'll squash it into that original patch before it gets upstream?

  Thomas
Gustavo Romero May 28, 2025, 12:11 p.m. UTC | #2
Hi Thomas,

On 5/28/25 04:57, Thomas Huth wrote:
> On 28/05/2025 03.47, Gustavo Romero wrote:
>> The current links for the Linux and initrd.gz images are not truly
>> immutable, so let's change them to point to immutable versions, to avoid
>> having to keep updating their SHAs.
>>
>> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
>> ---
>>   tests/functional/test_aarch64_hotplug_pci.py | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/functional/test_aarch64_hotplug_pci.py b/tests/functional/test_aarch64_hotplug_pci.py
>> index fa1bb62c8f..2cf5c28b9f 100755
>> --- a/tests/functional/test_aarch64_hotplug_pci.py
>> +++ b/tests/functional/test_aarch64_hotplug_pci.py
>> @@ -19,13 +19,13 @@ class HotplugPCI(LinuxKernelTest):
>>       ASSET_KERNEL = Asset(
>>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
>> -         'current/images/netboot/debian-installer/arm64/linux'),
>> -        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
>> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/linux'),
>> +         'd92a60392ce1e379ca198a1a820899f8f0d39a62d047c41ab79492f81541a9d9')
>>       ASSET_INITRD = Asset(
>>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
>> -         'current/images/netboot/debian-installer/arm64/initrd.gz'),
>> -        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
>> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/initrd.gz'),
>> +         '9f817f76951f3237bca8216bee35267bfb826815687f4b2fcdd5e6c2a917790c')
>>       def test_hotplug_pci(self):
> 
> Acked-by: Thomas Huth <thuth@redhat.com>
> 
> Since the original patch is still sitting in Alex' queue, I assume that he'll squash it into that original patch before it gets upstream?

Exactly. I have a meeting with him in a couple of hours and will ask him to queue it.


Cheers,
Gustavo
Gustavo Romero May 28, 2025, 8:55 p.m. UTC | #3
Hi Thomas,

On 5/28/25 09:11, Gustavo Romero wrote:
> Hi Thomas,
> 
> On 5/28/25 04:57, Thomas Huth wrote:
>> On 28/05/2025 03.47, Gustavo Romero wrote:
>>> The current links for the Linux and initrd.gz images are not truly
>>> immutable, so let's change them to point to immutable versions, to avoid
>>> having to keep updating their SHAs.
>>>
>>> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
>>> ---
>>>   tests/functional/test_aarch64_hotplug_pci.py | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/tests/functional/test_aarch64_hotplug_pci.py b/tests/functional/test_aarch64_hotplug_pci.py
>>> index fa1bb62c8f..2cf5c28b9f 100755
>>> --- a/tests/functional/test_aarch64_hotplug_pci.py
>>> +++ b/tests/functional/test_aarch64_hotplug_pci.py
>>> @@ -19,13 +19,13 @@ class HotplugPCI(LinuxKernelTest):
>>>       ASSET_KERNEL = Asset(
>>>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
>>> -         'current/images/netboot/debian-installer/arm64/linux'),
>>> -        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
>>> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/linux'),
>>> +         'd92a60392ce1e379ca198a1a820899f8f0d39a62d047c41ab79492f81541a9d9')
>>>       ASSET_INITRD = Asset(
>>>           ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
>>> -         'current/images/netboot/debian-installer/arm64/initrd.gz'),
>>> -        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
>>> +         '20230607+deb12u11/images/netboot/debian-installer/arm64/initrd.gz'),
>>> +         '9f817f76951f3237bca8216bee35267bfb826815687f4b2fcdd5e6c2a917790c')
>>>       def test_hotplug_pci(self):
>>
>> Acked-by: Thomas Huth <thuth@redhat.com>
>>
>> Since the original patch is still sitting in Alex' queue, I assume that he'll squash it into that original patch before it gets upstream?
> 
> Exactly. I have a meeting with him in a couple of hours and will ask him to queue it.

Alex had removed the original patch from his queue, so he asked me
to squash it with this one. I've posted the squashed version here:

https://lists.gnu.org/archive/html/qemu-devel/2025-05/msg06621.html


Cheers,
Gustavo
diff mbox series

Patch

diff --git a/tests/functional/test_aarch64_hotplug_pci.py b/tests/functional/test_aarch64_hotplug_pci.py
index fa1bb62c8f..2cf5c28b9f 100755
--- a/tests/functional/test_aarch64_hotplug_pci.py
+++ b/tests/functional/test_aarch64_hotplug_pci.py
@@ -19,13 +19,13 @@  class HotplugPCI(LinuxKernelTest):
 
     ASSET_KERNEL = Asset(
         ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
-         'current/images/netboot/debian-installer/arm64/linux'),
-        '3821d4db56d42c6a4eac62f31846e35465940afd87746b4cfcdf5c9eca3117b2')
+         '20230607+deb12u11/images/netboot/debian-installer/arm64/linux'),
+         'd92a60392ce1e379ca198a1a820899f8f0d39a62d047c41ab79492f81541a9d9')
 
     ASSET_INITRD = Asset(
         ('https://ftp.debian.org/debian/dists/stable/main/installer-arm64/'
-         'current/images/netboot/debian-installer/arm64/initrd.gz'),
-        '2583ec22b45265ad69e82f198674f53d4cd85be124fe012eedc2fd91156bc4b4')
+         '20230607+deb12u11/images/netboot/debian-installer/arm64/initrd.gz'),
+         '9f817f76951f3237bca8216bee35267bfb826815687f4b2fcdd5e6c2a917790c')
 
     def test_hotplug_pci(self):