| Message ID | 20250527-pf1550-v3-1-45f69453cd51@savoirfairelinux.com |
|---|---|
| State | New |
| Headers | show |
| Series | add support for pf1550 PMIC MFD-based drivers | expand |
On 28/05/2025 00:25, Samuel Kayode via B4 Relay wrote: > From: Samuel Kayode <samuel.kayode@savoirfairelinux.com> > > Add a DT binding document for pf1550 PMIC. This describes the core mfd > device along with its children: regulators, charger and onkey. > > Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com> > --- > v3: > - Address Krzysztof's feedback: > - Fold charger and onkey objects > - Drop compatible for sub-devices: onkey, charger and regulator. > - Drop constant voltage property already included in > monitored-battery > - Fix whitespace warnings > - Fix license > v2: > - Add yamls for the PMIC and the sub-devices > --- > Documentation/devicetree/bindings/mfd/pf1550.yaml | 139 ++++++++++++++++++++++ Filename: nothing improved. > 1 file changed, 139 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/pf1550.yaml b/Documentation/devicetree/bindings/mfd/pf1550.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..7f22cb91eb5542c8aa616525ed1e78efa2a863d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/pf1550.yaml ... > + > + patternProperties: > + "^(ldo[1-3]|sw[1-3]|vrefddr)$": > + type: object > + $ref: /schemas/regulator/regulator.yaml > + description: > + regulator configuration for ldo1-3, buck converters(sw1-3) > + and DDR termination reference voltage (vrefddr) > + unevaluatedProperties: false > + > + additionalProperties: false > + > + monitored-battery: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + A phandle to a monitored battery node that contains a valid value > + for: > + constant-charge-voltage-max-microvolt. > + > + fsl,thermal-regulation: -celsius or whatever is in standard suffixes: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml > + $ref: /schemas/types.yaml#/definitions/uint32 Drop > + description: > + Temperature threshold for thermal regulation of charger in celsius. But this now makes me wonder whether this should be just part of thermal zone and get the threshold from there. I assume this is temperature of CHARGER, not the battery. If battery, you have such properties in battery.yaml (monitored-batter). @Sebastian, Are there existing bindings or devices which regulate temperature based on thermal-zones in DT? > + enum: [ 60, 75, 90, 105 ] > + > + fsl,min-system-microvolt: > + description: > + System specific lower limit voltage. > + enum: [ 3500000, 3700000, 4300000 ] > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + battery: battery-cell { > + compatible = "simple-battery"; > + constant-charge-voltage-max-microvolt = <4400000>; > + operating-range-celsius = <0 75>; So this looks like duplicating thermal-regulation property. > + }; Blank line > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/input/linux-event-codes.h> Includes go before battery-cell. > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/pf1550.yaml b/Documentation/devicetree/bindings/mfd/pf1550.yaml new file mode 100644 index 0000000000000000000000000000000000000000..7f22cb91eb5542c8aa616525ed1e78efa2a863d3 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/pf1550.yaml @@ -0,0 +1,139 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/pf1550.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP PF1550 Power Management IC + +maintainers: + - Samuel Kayode <samuel.kayode@savoirfairelinux.com> + +description: | + PF1550 PMIC provides battery charging and power supply for low power IoT and + wearable applications. This device consists of an i2c controlled MFD that + includes regulators, battery charging and an onkey/power button. + +$ref: /schemas/power/supply/power-supply.yaml + +properties: + compatible: + const: fsl,pf1550 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + wakeup-source: true + + regulators: + type: object + + patternProperties: + "^(ldo[1-3]|sw[1-3]|vrefddr)$": + type: object + $ref: /schemas/regulator/regulator.yaml + description: + regulator configuration for ldo1-3, buck converters(sw1-3) + and DDR termination reference voltage (vrefddr) + unevaluatedProperties: false + + additionalProperties: false + + monitored-battery: + $ref: /schemas/types.yaml#/definitions/phandle + description: | + A phandle to a monitored battery node that contains a valid value + for: + constant-charge-voltage-max-microvolt. + + fsl,thermal-regulation: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Temperature threshold for thermal regulation of charger in celsius. + enum: [ 60, 75, 90, 105 ] + + fsl,min-system-microvolt: + description: + System specific lower limit voltage. + enum: [ 3500000, 3700000, 4300000 ] + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + battery: battery-cell { + compatible = "simple-battery"; + constant-charge-voltage-max-microvolt = <4400000>; + operating-range-celsius = <0 75>; + }; + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/input/linux-event-codes.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@8 { + compatible = "fsl,pf1550"; + reg = <0x8>; + + interrupt-parent = <&gpio1>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; + wakeup-source; + monitored-battery = <&battery>; + fsl,min-system-microvolt = <4300000>; + fsl,thermal-regulation = <75>; + + regulators { + sw1_reg: sw1 { + regulator-name = "sw1"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1387500>; + regulator-always-on; + regulator-ramp-delay = <6250>; + }; + + sw2_reg: sw2 { + regulator-name = "sw2"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1387500>; + regulator-always-on; + }; + + sw3_reg: sw3 { + regulator-name = "sw3"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vldo1_reg: ldo1 { + regulator-name = "ldo1"; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vldo2_reg: ldo2 { + regulator-name = "ldo2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vldo3_reg: ldo3 { + regulator-name = "ldo3"; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; + }; + };