diff mbox series

[v2,12/35] mmc: sdhci-esdhc-imx: Drop the use of sdhci_pltfm_free()

Message ID ab38dd89c744cc93db8d4fcd477cce7d104fc719.1748515612.git.zhoubinbin@loongson.cn
State New
Headers show
Series mmc: Cleanup sdhci_pltfm_free()/sdhci_free_host() usage | expand

Commit Message

Binbin Zhou May 29, 2025, 12:59 p.m. UTC
Since the devm_mmc_alloc_host() helper is already in use,
sdhci_pltfm_free() is no longer needed.

Cc: Haibo Chen <haibo.chen@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: imx@lists.linux.dev
Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Bough Chen May 30, 2025, 2:31 a.m. UTC | #1
> -----Original Message-----
> From: Binbin Zhou <zhoubinbin@loongson.cn>
> Sent: 2025年5月29日 20:59
> To: Binbin Zhou <zhoubb.aaron@gmail.com>; Huacai Chen
> <chenhuacai@loongson.cn>; Ulf Hansson <ulf.hansson@linaro.org>; Adrian
> Hunter <adrian.hunter@intel.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>; linux-mmc@vger.kernel.org;
> Andrew Jeffery <andrew@codeconstruct.com.au>; Binbin Zhou
> <zhoubinbin@loongson.cn>; Bough Chen <haibo.chen@nxp.com>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
> Estevam <festevam@gmail.com>; imx@lists.linux.dev
> Subject: [PATCH v2 12/35] mmc: sdhci-esdhc-imx: Drop the use of
> sdhci_pltfm_free()
> 
> Since the devm_mmc_alloc_host() helper is already in use,
> sdhci_pltfm_free() is no longer needed.

Reviewed-by: Haibo Chen <haibo.chen@nxp.com>

Thanks
Haibo
> 
> Cc: Haibo Chen <haibo.chen@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: imx@lists.linux.dev
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index ac187a8798b7..011b60d21a80 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1973,7 +1973,6 @@ static int sdhci_esdhc_imx_probe(struct
> platform_device *pdev)
>  free_sdhci:
>  	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
>  		cpu_latency_qos_remove_request(&imx_data->pm_qos_req);
> -	sdhci_pltfm_free(pdev);
>  	return err;
>  }
> 
> @@ -1997,8 +1996,6 @@ static void sdhci_esdhc_imx_remove(struct
> platform_device *pdev)
> 
>  	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
>  		cpu_latency_qos_remove_request(&imx_data->pm_qos_req);
> -
> -	sdhci_pltfm_free(pdev);
>  }
> 
>  #ifdef CONFIG_PM_SLEEP
> --
> 2.47.1
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index ac187a8798b7..011b60d21a80 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -1973,7 +1973,6 @@  static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
 free_sdhci:
 	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
 		cpu_latency_qos_remove_request(&imx_data->pm_qos_req);
-	sdhci_pltfm_free(pdev);
 	return err;
 }
 
@@ -1997,8 +1996,6 @@  static void sdhci_esdhc_imx_remove(struct platform_device *pdev)
 
 	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
 		cpu_latency_qos_remove_request(&imx_data->pm_qos_req);
-
-	sdhci_pltfm_free(pdev);
 }
 
 #ifdef CONFIG_PM_SLEEP