diff mbox series

efi/libstub: use 'targets' instead of extra-y in Makefile

Message ID 20250602181143.528789-1-masahiroy@kernel.org
State New
Headers show
Series efi/libstub: use 'targets' instead of extra-y in Makefile | expand

Commit Message

Masahiro Yamada June 2, 2025, 6:11 p.m. UTC
These objects are built as prerequisites of %.stub.o files.
There is no need to use extra-y, which is planned for deprecation.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/firmware/efi/libstub/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada June 5, 2025, 8:42 p.m. UTC | #1
On Tue, Jun 3, 2025 at 3:13 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 2 Jun 2025 at 20:11, Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > These objects are built as prerequisites of %.stub.o files.
> > There is no need to use extra-y, which is planned for deprecation.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> I misunderstood what extra-y was for - note that
> arch/arm64/kernel/pi/Makefile has the same issue.

Applied to linux-kbuild.


A patch exists for arm64 too

https://lore.kernel.org/lkml/20250602180937.528459-1-masahiroy@kernel.org/
diff mbox series

Patch

diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index d23a1b9fed75..5ce9f2098b99 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -102,7 +102,7 @@  lib-$(CONFIG_EFI_ZBOOT)		+= zboot.o $(zboot-obj-y)
 
 lib-$(CONFIG_UNACCEPTED_MEMORY) += unaccepted_memory.o bitmap.o find.o
 
-extra-y				:= $(lib-y)
+targets				:= $(lib-y)
 lib-y				:= $(patsubst %.o,%.stub.o,$(lib-y))
 
 # Even when -mbranch-protection=none is set, Clang will generate a