| Message ID | 20250604-sm8550-correct-vreg_l6n_3p3-voltage-v1-1-18cd01a69ac6@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sm8550: Correct the max voltage for vreg_l6n_3p3 | expand |
On 04/06/2025 08:27, Kamal Wadhwa wrote: > Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently > configured at 3304000uV in different sm8550 board files. However this > is not a valid voltage value for 'pmic5_pldo502ln' type voltage > regulators. > > Check below the max value(3200mV) in the regulator summary for min/max > used as 2800mV/3304mV in DT:- > > logs: > > [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV > > regulator summary: > > regulator use open bypass opmode voltage current min max > --------------------------------------------------------------------- > .. > vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV > .. > > Correct the max value to 3200000uV, so that it is aligned to voltages > allowed by the regulator. > > Also, correct the phandle name of 'vreg_l6n_3p3' to 'vreg_l6n_3p2', > so it reflect this change in settings. > > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 6 +++--- > 4 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > index 29bc1ddfc7b25f203c9f3b530610e45c44ae4fb2..fe46699804b3a8fb792edc06b58b961778cd8d70 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > @@ -857,10 +857,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 5648ab60ba4c4bfaf5baa289969898277ee57cef..1e95a2849146e3eeea9f68085ac504e32b63fdaf 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -624,10 +624,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index 3a6cb279130489168f8d20a6e27808647debdb41..5a33d7d7ac923c7c0bf6aeb51d0db728e65883ac 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -700,10 +700,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > index 7d29a57a2b540708fa88fb59e821406f400a3174..073040fbd7ba215169adbe3862d3e1f6d2c786e0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > @@ -485,10 +485,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > > --- > base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc > change-id: 20250603-sm8550-correct-vreg_l6n_3p3-voltage-cba298bc0294 > > Best regards, Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On Wed, Jun 04, 2025 at 11:57:22AM +0530, Kamal Wadhwa wrote: > Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently > configured at 3304000uV in different sm8550 board files. However this > is not a valid voltage value for 'pmic5_pldo502ln' type voltage > regulators. > > Check below the max value(3200mV) in the regulator summary for min/max > used as 2800mV/3304mV in DT:- > > logs: > > [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV > > regulator summary: > > regulator use open bypass opmode voltage current min max > --------------------------------------------------------------------- > .. > vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV > .. > > Correct the max value to 3200000uV, so that it is aligned to voltages > allowed by the regulator. > > Also, correct the phandle name of 'vreg_l6n_3p3' to 'vreg_l6n_3p2', > so it reflect this change in settings. > > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 6 +++--- > 4 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > index 29bc1ddfc7b25f203c9f3b530610e45c44ae4fb2..fe46699804b3a8fb792edc06b58b961778cd8d70 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > @@ -857,10 +857,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { Please follow the naming from the board's schematics for the label and regulator-name. > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; The name of this regulator indicates that it's a 3.3V (or 3.2V, although unlikely) rail. But regulator framework will use the min/max from DeviceTree combined with any regulator_set_voltage() requests (if there are any) and pick the lowest possible value in the resulting range. As we regulator_set_voltage() votes tends to be the exception, this looks like a 2.8V rail. Can you please confirm what voltage is expected here? If 2.8V is correct, please make max (a valid variant of) 2.8V. Regards, Bjorn > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 5648ab60ba4c4bfaf5baa289969898277ee57cef..1e95a2849146e3eeea9f68085ac504e32b63fdaf 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -624,10 +624,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index 3a6cb279130489168f8d20a6e27808647debdb41..5a33d7d7ac923c7c0bf6aeb51d0db728e65883ac 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -700,10 +700,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > index 7d29a57a2b540708fa88fb59e821406f400a3174..073040fbd7ba215169adbe3862d3e1f6d2c786e0 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts > @@ -485,10 +485,10 @@ vreg_l5n_1p8: ldo5 { > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > - vreg_l6n_3p3: ldo6 { > - regulator-name = "vreg_l6n_3p3"; > + vreg_l6n_3p2: ldo6 { > + regulator-name = "vreg_l6n_3p2"; > regulator-min-microvolt = <2800000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <3200000>; > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > }; > > > --- > base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc > change-id: 20250603-sm8550-correct-vreg_l6n_3p3-voltage-cba298bc0294 > > Best regards, > -- > Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> >
diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts index 29bc1ddfc7b25f203c9f3b530610e45c44ae4fb2..fe46699804b3a8fb792edc06b58b961778cd8d70 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts @@ -857,10 +857,10 @@ vreg_l5n_1p8: ldo5 { regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; - vreg_l6n_3p3: ldo6 { - regulator-name = "vreg_l6n_3p3"; + vreg_l6n_3p2: ldo6 { + regulator-name = "vreg_l6n_3p2"; regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index 5648ab60ba4c4bfaf5baa289969898277ee57cef..1e95a2849146e3eeea9f68085ac504e32b63fdaf 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -624,10 +624,10 @@ vreg_l5n_1p8: ldo5 { regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; - vreg_l6n_3p3: ldo6 { - regulator-name = "vreg_l6n_3p3"; + vreg_l6n_3p2: ldo6 { + regulator-name = "vreg_l6n_3p2"; regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts index 3a6cb279130489168f8d20a6e27808647debdb41..5a33d7d7ac923c7c0bf6aeb51d0db728e65883ac 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts @@ -700,10 +700,10 @@ vreg_l5n_1p8: ldo5 { regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; - vreg_l6n_3p3: ldo6 { - regulator-name = "vreg_l6n_3p3"; + vreg_l6n_3p2: ldo6 { + regulator-name = "vreg_l6n_3p2"; regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; diff --git a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts index 7d29a57a2b540708fa88fb59e821406f400a3174..073040fbd7ba215169adbe3862d3e1f6d2c786e0 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts @@ -485,10 +485,10 @@ vreg_l5n_1p8: ldo5 { regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; }; - vreg_l6n_3p3: ldo6 { - regulator-name = "vreg_l6n_3p3"; + vreg_l6n_3p2: ldo6 { + regulator-name = "vreg_l6n_3p2"; regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <3304000>; + regulator-max-microvolt = <3200000>; regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; };
Voltage regulator 'vreg_l6n_3p3' max-microvolt prop is currently configured at 3304000uV in different sm8550 board files. However this is not a valid voltage value for 'pmic5_pldo502ln' type voltage regulators. Check below the max value(3200mV) in the regulator summary for min/max used as 2800mV/3304mV in DT:- logs: [ 0.294781] vreg_l6n_3p3: Setting 2800000-3304000uV regulator summary: regulator use open bypass opmode voltage current min max --------------------------------------------------------------------- .. vreg_l6n_3p3 0 0 0 normal 2800mV 0mA 2800mV 3200mV .. Correct the max value to 3200000uV, so that it is aligned to voltages allowed by the regulator. Also, correct the phandle name of 'vreg_l6n_3p3' to 'vreg_l6n_3p2', so it reflect this change in settings. Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 6 +++--- arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 6 +++--- arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 6 +++--- arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) --- base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc change-id: 20250603-sm8550-correct-vreg_l6n_3p3-voltage-cba298bc0294 Best regards,