| Message ID | 20250604100342.128769-1-lijun01@kylinos.cn |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: arcmsr: return the value of fun directly | expand |
On 04.06.25 12:04, Li Jun wrote: > return pci_register_driver directly,just look clean. > > Signed-off-by: Li Jun <lijun01@kylinos.cn> > --- > drivers/scsi/arcmsr/arcmsr_hba.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c > index b450b1fc6bbb..c3a71a3fdcd0 100644 > --- a/drivers/scsi/arcmsr/arcmsr_hba.c > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c > @@ -1777,9 +1777,7 @@ static void arcmsr_shutdown(struct pci_dev *pdev) > > static int __init arcmsr_module_init(void) > { > - int error = 0; > - error = pci_register_driver(&arcmsr_pci_driver); > - return error; > + return pci_register_driver(&arcmsr_pci_driver); > } > > static void __exit arcmsr_module_exit(void) Why not module_pci_driver(arcmsr_pci_driver) if you want to make it look cleaner?
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index b450b1fc6bbb..c3a71a3fdcd0 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -1777,9 +1777,7 @@ static void arcmsr_shutdown(struct pci_dev *pdev) static int __init arcmsr_module_init(void) { - int error = 0; - error = pci_register_driver(&arcmsr_pci_driver); - return error; + return pci_register_driver(&arcmsr_pci_driver); } static void __exit arcmsr_module_exit(void)
return pci_register_driver directly,just look clean. Signed-off-by: Li Jun <lijun01@kylinos.cn> --- drivers/scsi/arcmsr/arcmsr_hba.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)