| Message ID | 20250607033228.1475625-2-dan.j.williams@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | CXL: ACPI: faux: Fix cxl_core.ko module load regression | expand |
On Fri, 6 Jun 2025 20:32:26 -0700 Dan Williams <dan.j.williams@intel.com> wrote: > faux_device_create() is almost a suitable candidate to replace > platform_driver_probe() if not for the fact that faux_device_create() > supports dynamic attach/detach of the driver. > > Drop the bind attributes with the expectation that simple faux devices can > always assume that the device is permanently bound at create, and only > unbound at 'destroy'. > > The acpi-einj driver depends on static bind. > > Fixes: 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface") > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Danilo Krummrich <dakr@kernel.org> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Seems like a fair assumption that these should never be used so we might as well hide the. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/base/faux.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/faux.c b/drivers/base/faux.c > index 9054d346bd7f..934da77ca48b 100644 > --- a/drivers/base/faux.c > +++ b/drivers/base/faux.c > @@ -86,6 +86,7 @@ static struct device_driver faux_driver = { > .name = "faux_driver", > .bus = &faux_bus_type, > .probe_type = PROBE_FORCE_SYNCHRONOUS, > + .suppress_bind_attrs = true, > }; > > static void faux_device_release(struct device *dev)
diff --git a/drivers/base/faux.c b/drivers/base/faux.c index 9054d346bd7f..934da77ca48b 100644 --- a/drivers/base/faux.c +++ b/drivers/base/faux.c @@ -86,6 +86,7 @@ static struct device_driver faux_driver = { .name = "faux_driver", .bus = &faux_bus_type, .probe_type = PROBE_FORCE_SYNCHRONOUS, + .suppress_bind_attrs = true, }; static void faux_device_release(struct device *dev)
faux_device_create() is almost a suitable candidate to replace platform_driver_probe() if not for the fact that faux_device_create() supports dynamic attach/detach of the driver. Drop the bind attributes with the expectation that simple faux devices can always assume that the device is permanently bound at create, and only unbound at 'destroy'. The acpi-einj driver depends on static bind. Fixes: 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface") Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Danilo Krummrich <dakr@kernel.org> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/base/faux.c | 1 + 1 file changed, 1 insertion(+)