| Message ID | 20250611-fix_vd55g1-v3-2-ef4ecf15ddbc@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: vd55g1: Miscellaneous fixes | expand |
Hi Benjamin, On Wed, Jun 11, 2025 at 10:48:31AM +0200, Benjamin Mugnier wrote: > Enable stream was returning success even if an error occurred, fix it by > modifying the err_rpm_put return value to -EINVAL. > > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> This looks like something that should be backported btw. What's the Fixes: header? I can add that while applying.
diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c index 78dd22d9cab03edf4ff3e5a301f8d045e930c997..336dc3c85ac9e695f22aa524e0df6138dc76e45c 100644 --- a/drivers/media/i2c/vd55g1.c +++ b/drivers/media/i2c/vd55g1.c @@ -1084,7 +1084,7 @@ static int vd55g1_enable_streams(struct v4l2_subdev *sd, err_rpm_put: pm_runtime_put(sensor->dev); - return 0; + return -EINVAL; } static int vd55g1_disable_streams(struct v4l2_subdev *sd,
Enable stream was returning success even if an error occurred, fix it by modifying the err_rpm_put return value to -EINVAL. Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> --- drivers/media/i2c/vd55g1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)