| Message ID | 20250613134817.681832-7-herve.codina@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | lan966x pci device: Add support for SFPs | expand |
On Fri, Jun 13, 2025 at 6:49 AM Herve Codina <herve.codina@bootlin.com> wrote: > > Setting fwnode->dev is specific to fw_devlink. > > In order to avoid having a direct 'fwnode->dev = dev;' in several > place in the kernel, introduce fw_devlink_set_device() helper to perform > this operation. > This should not be set anywhere outside the driver core files. I'll get to reviewing the series, but until then, NACK to this. Is there a specific patch that explain why we need to set this outside driver core? -Saravana > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > include/linux/fwnode.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > index a921ca2fe940..a1345e274125 100644 > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -231,4 +231,10 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode); > void fw_devlink_refresh_fwnode(struct fwnode_handle *fwnode); > bool fw_devlink_is_strict(void); > > +static inline void fw_devlink_set_device(struct fwnode_handle *fwnode, > + struct device *dev) > +{ > + fwnode->dev = dev; > +} > + > #endif > -- > 2.49.0 >
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index a921ca2fe940..a1345e274125 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -231,4 +231,10 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode); void fw_devlink_refresh_fwnode(struct fwnode_handle *fwnode); bool fw_devlink_is_strict(void); +static inline void fw_devlink_set_device(struct fwnode_handle *fwnode, + struct device *dev) +{ + fwnode->dev = dev; +} + #endif
Setting fwnode->dev is specific to fw_devlink. In order to avoid having a direct 'fwnode->dev = dev;' in several place in the kernel, introduce fw_devlink_set_device() helper to perform this operation. Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- include/linux/fwnode.h | 6 ++++++ 1 file changed, 6 insertions(+)