| Message ID | 20250613071627.46687-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping | expand |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Fri, 13 Jun 2025 09:16:28 +0200, Krzysztof Kozlowski wrote: > It is very useful to find driver implementing compatibles with `git grep > compatible`, so driver should not use defines for that string, even if > this means string will be effectively duplicated. > > Applied, thanks! [1/1] gpio: sloppy-logic-analyzer: Fully open-code compatible for grepping https://git.kernel.org/brgl/linux/c/bddfad9f7ef3fc73f0a6fb05996719adcb5082fc Best regards,
diff --git a/drivers/gpio/gpio-sloppy-logic-analyzer.c b/drivers/gpio/gpio-sloppy-logic-analyzer.c index 8cf3b171c599..969dddd3d6fa 100644 --- a/drivers/gpio/gpio-sloppy-logic-analyzer.c +++ b/drivers/gpio/gpio-sloppy-logic-analyzer.c @@ -306,7 +306,7 @@ static void gpio_la_poll_remove(struct platform_device *pdev) } static const struct of_device_id gpio_la_poll_of_match[] = { - { .compatible = GPIO_LA_NAME }, + { .compatible = "gpio-sloppy-logic-analyzer" }, { } }; MODULE_DEVICE_TABLE(of, gpio_la_poll_of_match);
It is very useful to find driver implementing compatibles with `git grep compatible`, so driver should not use defines for that string, even if this means string will be effectively duplicated. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpio/gpio-sloppy-logic-analyzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)