| Message ID | 20170110100931.15791-1-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 10, 2017 at 2:09 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > This adds the Qualcomm External Bus Interface 2 to the multi_v7 > defconfig: it is hard for users to realize that this is a > required driver for getting things like ethernet, and a necessary > prerequisite to get the external bus discoverable on the > MSM8660/APQ8060 machines. Is it the kind of option that should really be selected through Kconfig instead for those platforms? I.e. is it ever really likely that we'll want it off? -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jan 10, 2017 at 7:02 PM, Olof Johansson <olof@lixom.net> wrote: > On Tue, Jan 10, 2017 at 2:09 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> This adds the Qualcomm External Bus Interface 2 to the multi_v7 >> defconfig: it is hard for users to realize that this is a >> required driver for getting things like ethernet, and a necessary >> prerequisite to get the external bus discoverable on the >> MSM8660/APQ8060 machines. > > Is it the kind of option that should really be selected through > Kconfig instead for those platforms? Stephen Boyd question. AFAIK the ambition is to go with the platform to have zero stuff in mach-qcom/* and thus it all becomes a defconfig thing. > I.e. is it ever really likely that we'll want it off? Not really, if this chip should be supported in the resulting image. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 01/11/2017 07:22 AM, Linus Walleij wrote: > On Tue, Jan 10, 2017 at 7:02 PM, Olof Johansson <olof@lixom.net> wrote: >> On Tue, Jan 10, 2017 at 2:09 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >>> This adds the Qualcomm External Bus Interface 2 to the multi_v7 >>> defconfig: it is hard for users to realize that this is a >>> required driver for getting things like ethernet, and a necessary >>> prerequisite to get the external bus discoverable on the >>> MSM8660/APQ8060 machines. >> Is it the kind of option that should really be selected through >> Kconfig instead for those platforms? > Stephen Boyd question. > > AFAIK the ambition is to go with the platform to have zero > stuff in mach-qcom/* and thus it all becomes a defconfig > thing. It could be made a 'default ARCH_QCOM' type of thing. Then the config doesn't need an update unless you want to turn it off. I imagine people would want to turn it off if they're using a board with a qcom SoC that isn't 8660, which is probably going to stay the majority forever. It's true I've been pushing to get rid of the ARCH_MSM* configs in mach-qcom/Kconfig as they lead to confusion about what qcom SoCs are supported in mainline and cause config options to become outdated each time a new SoC comes out that supports some particular driver. I'll go repush those changes. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Jan 12, 2017 at 2:01 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 01/11/2017 07:22 AM, Linus Walleij wrote: >> On Tue, Jan 10, 2017 at 7:02 PM, Olof Johansson <olof@lixom.net> wrote: >>> On Tue, Jan 10, 2017 at 2:09 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >>>> This adds the Qualcomm External Bus Interface 2 to the multi_v7 >>>> defconfig: it is hard for users to realize that this is a >>>> required driver for getting things like ethernet, and a necessary >>>> prerequisite to get the external bus discoverable on the >>>> MSM8660/APQ8060 machines. >>> Is it the kind of option that should really be selected through >>> Kconfig instead for those platforms? >> >> Stephen Boyd question. >> >> AFAIK the ambition is to go with the platform to have zero >> stuff in mach-qcom/* and thus it all becomes a defconfig >> thing. > > It could be made a 'default ARCH_QCOM' type of thing. Then the config > doesn't need an update unless you want to turn it off. OK I will do that. Olof: let's scrap this patch. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index b01a43851294..267d0703caae 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -192,6 +192,7 @@ CONFIG_DEVTMPFS_MOUNT=y CONFIG_DMA_CMA=y CONFIG_CMA_SIZE_MBYTES=64 CONFIG_OMAP_OCP2SCP=y +CONFIG_QCOM_EBI2=y CONFIG_SIMPLE_PM_BUS=y CONFIG_SUNXI_RSB=m CONFIG_MTD=y
This adds the Qualcomm External Bus Interface 2 to the multi_v7 defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines. As regular users will likely want to have some ethernet and other functionality up quickly, it makes sense to add this to the multi_v7 defconfig. Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ARM SoC folks: please just apply this wherever ARM multi_v7 defconfigs go if you're OK with it. --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel