[v2,08/13] pinctrl: samsung: Remove dead code

Message ID	1484657084-26227-9-git-send-email-m.szyprowski@samsung.com
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Marek Szyprowski <m.szyprowski@samsung.com> To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski <m.szyprowski@samsung.com>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Krzysztof Kozlowski <krzk@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Tomasz Figa <tomasz.figa@gmail.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: [PATCH v2 08/13] pinctrl: samsung: Remove dead code Date: Tue, 17 Jan 2017 13:44:39 +0100 Message-id: <1484657084-26227-9-git-send-email-m.szyprowski@samsung.com> In-reply-to: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com> CMS-TYPE: 201P References: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com> <CGME20170117124500eucas1p265447c459ad0ac0a79dc3d3c833d09f6@eucas1p2.samsung.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk
Series	Move pad retention control to Exynos pin controller driver \| expand [v2,00/13] Move pad retention control to Exynos pin controller driver [v2,01/13] soc: samsung: pmu: Provide global function to get PMU regmap [v2,02/13] soc: samsung: pmu: Use of_device_get_match_data helper [v2,03/13] soc: samsung: pmu: Remove messages for failed memory allocation [v2,04/13] pinctrl: samsung: Document Exynos3250 SoC support [v2,05/13] pinctrl: samsung: Remove messages for failed memory allocation [v2,06/13] pinctrl: samsung: Fix samsung_pinctrl_create_functions return value [v2,07/13] pinctrl: samsung: Add missing initconst annotation [v2,08/13] pinctrl: samsung: Remove dead code [v2,09/13] pinctrl: samsung: Use generic of_device_get_match_data helper [v2,10/13] pinctrl: samsung: Add infrastructure for pin-bank retention control [v2,11/13] pinctrl: samsung: Move retention control from mach-exynos to the pinctrl driver [v2,12/13] pinctrl: samsung: Move retention control from mach-s5pv210 to the pinctrl driver [v2,13/13] pinctrl: samsung: Replace syscore ops with standard platform device pm_ops

Message ID

1484657084-26227-9-git-send-email-m.szyprowski@samsung.com

State

Superseded

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-pm-owner@vger.kernel.org designates 209.132.180.67 as
	permitted sender) client-ip=209.132.180.67; 
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v2 08/13] pinctrl: samsung: Remove dead code
Date: Tue, 17 Jan 2017 13:44:39 +0100
Message-id: <1484657084-26227-9-git-send-email-m.szyprowski@samsung.com>
In-reply-to: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com>
CMS-TYPE: 201P
References: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com>
	<CGME20170117124500eucas1p265447c459ad0ac0a79dc3d3c833d09f6@eucas1p2.samsung.com>
Sender: linux-pm-owner@vger.kernel.org
Precedence: bulk

Series

Move pad retention control to Exynos pin controller driver | expand

Commit Message

Marek Szyprowski Jan. 17, 2017, 12:44 p.m. UTC

'enable' parameter has been removed a while ago, so all code for handling
it can be simply removed.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index 10b3fd826231..2803ae57f373 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -350,7 +350,7 @@  static void pin_to_reg_bank(struct samsung_pinctrl_drv_data *drvdata,
 
 /* enable or disable a pinmux function */
 static void samsung_pinmux_setup(struct pinctrl_dev *pctldev, unsigned selector,
-					unsigned group, bool enable)
+					unsigned group)
 {
 	struct samsung_pinctrl_drv_data *drvdata;
 	const struct samsung_pin_bank_type *type;
@@ -380,8 +380,7 @@  static void samsung_pinmux_setup(struct pinctrl_dev *pctldev, unsigned selector,
 
 	data = readl(reg + type->reg_offset[PINCFG_TYPE_FUNC]);
 	data &= ~(mask << shift);
-	if (enable)
-		data |= func->val << shift;
+	data |= func->val << shift;
 	writel(data, reg + type->reg_offset[PINCFG_TYPE_FUNC]);
 
 	spin_unlock_irqrestore(&bank->slock, flags);
@@ -392,7 +391,7 @@  static int samsung_pinmux_set_mux(struct pinctrl_dev *pctldev,
 				  unsigned selector,
 				  unsigned group)
 {
-	samsung_pinmux_setup(pctldev, selector, group, true);
+	samsung_pinmux_setup(pctldev, selector, group);
 	return 0;
 }

[v2,08/13] pinctrl: samsung: Remove dead code

Commit Message

Patch