diff mbox

[1/1] ARM: SAMSUNG: Remove description corresponding to a deleted element

Message ID 1339479059-18527-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat June 12, 2012, 5:30 a.m. UTC
Commit 3c582647a9f84affd5c86e89d548157c62f8d9ca removed the default_win
element from the structure, but the description was not removed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/plat-samsung/include/plat/fb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Kukjin Kim June 19, 2012, 8:51 a.m. UTC | #1
Sachin Kamat wrote:
> 
> Commit 3c582647a9f84affd5c86e89d548157c62f8d9ca removed the default_win

In this case, 8 or 12 digits commit id is enough and please explain the
subject like following next time.

Commit 3c582647a9f8 ("video: s3c-fb: remove 'default_win' element from
platform data")...

> element from the structure, but the description was not removed.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/plat-samsung/include/plat/fb.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/fb.h b/arch/arm/plat-
> samsung/include/plat/fb.h
> index 536002f..b885322 100644
> --- a/arch/arm/plat-samsung/include/plat/fb.h
> +++ b/arch/arm/plat-samsung/include/plat/fb.h
> @@ -43,7 +43,6 @@ struct s3c_fb_pd_win {
>   * @setup_gpio: Setup the external GPIO pins to the right state to
> transfer
>   *		the data from the display system to the connected display
>   *		device.
> - * @default_win: default window layer number to be used for UI layer.
>   * @vidcon0: The base vidcon0 values to control the panel data format.
>   * @vidcon1: The base vidcon1 values to control the panel data output.
>   * @vtiming: Video timing when connected to a RGB type panel.
> --
> 1.7.4.1

Will apply after updating commit log I said.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Sachin Kamat June 19, 2012, 9:32 a.m. UTC | #2
On 19/06/2012, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> Commit 3c582647a9f84affd5c86e89d548157c62f8d9ca removed the default_win
>
> In this case, 8 or 12 digits commit id is enough and please explain the
> subject like following next time.

Ok.

>
> Commit 3c582647a9f8 ("video: s3c-fb: remove 'default_win' element from
> platform data")...
>
>> element from the structure, but the description was not removed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  arch/arm/plat-samsung/include/plat/fb.h |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/include/plat/fb.h b/arch/arm/plat-
>> samsung/include/plat/fb.h
>> index 536002f..b885322 100644
>> --- a/arch/arm/plat-samsung/include/plat/fb.h
>> +++ b/arch/arm/plat-samsung/include/plat/fb.h
>> @@ -43,7 +43,6 @@ struct s3c_fb_pd_win {
>>   * @setup_gpio: Setup the external GPIO pins to the right state to
>> transfer
>>   *		the data from the display system to the connected display
>>   *		device.
>> - * @default_win: default window layer number to be used for UI layer.
>>   * @vidcon0: The base vidcon0 values to control the panel data format.
>>   * @vidcon1: The base vidcon1 values to control the panel data output.
>>   * @vtiming: Video timing when connected to a RGB type panel.
>> --
>> 1.7.4.1
>
> Will apply after updating commit log I said.

Thanks :)

>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
diff mbox

Patch

diff --git a/arch/arm/plat-samsung/include/plat/fb.h b/arch/arm/plat-samsung/include/plat/fb.h
index 536002f..b885322 100644
--- a/arch/arm/plat-samsung/include/plat/fb.h
+++ b/arch/arm/plat-samsung/include/plat/fb.h
@@ -43,7 +43,6 @@  struct s3c_fb_pd_win {
  * @setup_gpio: Setup the external GPIO pins to the right state to transfer
  *		the data from the display system to the connected display
  *		device.
- * @default_win: default window layer number to be used for UI layer.
  * @vidcon0: The base vidcon0 values to control the panel data format.
  * @vidcon1: The base vidcon1 values to control the panel data output.
  * @vtiming: Video timing when connected to a RGB type panel.