diff mbox series

[PULL,17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls()

Message ID 7d628e2c05e0fd2da04f618ba41068a7c11b2a7d.1485250702.git.mjt@msgid.tls.msk.ru
State Accepted
Commit a1f910875668d87e139e79fce38e9c2e1c3747dd
Headers show
Series None | expand

Commit Message

Michael Tokarev Jan. 24, 2017, 9:39 a.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


The patch_hypercalls() function sets up a 'patches'
variable and checks it at the end of the function, but
never modifies it in the middle. Remove this dead code,
which seems to have been present since the function was
added in commit e5ad936b0fd7 in 2012.

(Spotted by Coverity: CID 1005581.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

---
 hw/i386/kvmvapic.c | 6 ------
 1 file changed, 6 deletions(-)

-- 
2.1.4
diff mbox series

Patch

diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index 2f767b6..702e281 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -535,7 +535,6 @@  static int patch_hypercalls(VAPICROMState *s)
     uint8_t alternates[2];
     const uint8_t *pattern;
     const uint8_t *patch;
-    int patches = 0;
     off_t pos;
     uint8_t *rom;
 
@@ -566,11 +565,6 @@  static int patch_hypercalls(VAPICROMState *s)
     }
 
     g_free(rom);
-
-    if (patches != 0 && patches != 2) {
-        return -1;
-    }
-
     return 0;
 }