| Message ID | 1486179006-10574-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 1f4f5e52e5afba8c1be15b9f6be187ad016f03e9 |
| Headers | show |
On 3 February 2017 at 19:30, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > There are two typos in the comment "invalide i-cache is enabled". > We can fix it by > invalide -> invalidate > is -> if > > Or, if we want to match the comment to the code, we can say > "skip invalidating i-cache if disabled". > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/arm/lib/relocate_64.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Sat, Feb 04, 2017 at 12:30:06PM +0900, Masahiro Yamada wrote: > There are two typos in the comment "invalide i-cache is enabled". > We can fix it by > invalide -> invalidate > is -> if > > Or, if we want to match the comment to the code, we can say > "skip invalidating i-cache if disabled". > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks! -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/arch/arm/lib/relocate_64.S b/arch/arm/lib/relocate_64.S index 242e56e..c760053 100644 --- a/arch/arm/lib/relocate_64.S +++ b/arch/arm/lib/relocate_64.S @@ -68,7 +68,7 @@ relocate_done: b 0f 1: mrs x0, sctlr_el1 0: tbz w0, #2, 5f /* skip flushing cache if disabled */ - tbz w0, #12, 4f /* invalide i-cache is enabled */ + tbz w0, #12, 4f /* skip invalidating i-cache if disabled */ ic iallu /* i-cache invalidate all */ isb sy 4: ldp x0, x1, [sp, #16]
There are two typos in the comment "invalide i-cache is enabled". We can fix it by invalide -> invalidate is -> if Or, if we want to match the comment to the code, we can say "skip invalidating i-cache if disabled". Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/arm/lib/relocate_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot