| Message ID | 1486890524-26918-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 433cbfb3b37404d6150a1aba94309bc0ed661689 |
| Headers | show |
Am 12.02.2017 um 10:08 schrieb Masahiro Yamada: > These two functions are only used in lib/tiny-printf.c . > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > lib/tiny-printf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Builds okay for ci20 (but does not resolve its size issue), Tested-by: Andreas Färber <afaerber@suse.de> Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On 12.02.2017 10:08, Masahiro Yamada wrote: > These two functions are only used in lib/tiny-printf.c . > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > lib/tiny-printf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c > index dfa8432..6def8f9 100644 > --- a/lib/tiny-printf.c > +++ b/lib/tiny-printf.c > @@ -22,7 +22,7 @@ struct printf_info { > void (*putc)(struct printf_info *info, char ch); > }; > > -void putc_normal(struct printf_info *info, char ch) > +static void putc_normal(struct printf_info *info, char ch) > { > putc(ch); > } > @@ -52,7 +52,7 @@ static void div_out(struct printf_info *info, unsigned long *num, > out_dgt(info, dgt); > } > > -int _vprintf(struct printf_info *info, const char *fmt, va_list va) > +static int _vprintf(struct printf_info *info, const char *fmt, va_list va) > { > char ch; > char *p; > Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Sun, Feb 12, 2017 at 06:08:43PM +0900, Masahiro Yamada wrote: > These two functions are only used in lib/tiny-printf.c . > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Tested-by: Andreas Färber <afaerber@suse.de> > Reviewed-by: Stefan Roese <sr@denx.de> Applied to u-boot/master, thanks! -- Tom
diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c index dfa8432..6def8f9 100644 --- a/lib/tiny-printf.c +++ b/lib/tiny-printf.c @@ -22,7 +22,7 @@ struct printf_info { void (*putc)(struct printf_info *info, char ch); }; -void putc_normal(struct printf_info *info, char ch) +static void putc_normal(struct printf_info *info, char ch) { putc(ch); } @@ -52,7 +52,7 @@ static void div_out(struct printf_info *info, unsigned long *num, out_dgt(info, dgt); } -int _vprintf(struct printf_info *info, const char *fmt, va_list va) +static int _vprintf(struct printf_info *info, const char *fmt, va_list va) { char ch; char *p;
These two functions are only used in lib/tiny-printf.c . Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- lib/tiny-printf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot