| Message ID | e9c3eaccf98c6cb41cf985c52a59c9562c9e9b25.1489534345.git.raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 759eed2b02e0a7b5c8b19d4b087d9151c009eed4 |
| Headers | show |
| Series | mesa/go/binutils fixes | expand |
On 14 March 2017 at 23:35, Khem Raj <raj.khem@gmail.com> wrote: > Currently we enable threaded linking feature of gold linker only > when its used as default ld. There is no need to restrict it when > its not default linker either. As long as gold is enabled, which > is the case here, we should be able to do threaded linking. > Turns out this broke meta-mingw's Windows SDKS (reproducible if you set SDKMACHINE = "i686-mingw32" and build binutils-cross). I've sent a patch to set LDGOLD to '' on mingw, but your comments are welcome on alternative fixes. Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc index 9b1192b6e7..37813dd864 100644 --- a/meta/recipes-devtools/binutils/binutils.inc +++ b/meta/recipes-devtools/binutils/binutils.inc @@ -78,7 +78,7 @@ EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \ LDGOLD_class-native = "" LDGOLD_class-crosssdk = "" -LDGOLD ?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default --enable-threads', '--enable-gold --enable-ld=default', d)}" +LDGOLD ?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default --enable-threads', '--enable-gold --enable-ld=default --enable-threads', d)}" # This is necessary due to a bug in the binutils Makefiles # EXTRA_OEMAKE = "configure-build-libiberty all"
Currently we enable threaded linking feature of gold linker only when its used as default ld. There is no need to restrict it when its not default linker either. As long as gold is enabled, which is the case here, we should be able to do threaded linking. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-devtools/binutils/binutils.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.12.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core