| Message ID | 1491315753-17805-1-git-send-email-ross.burton@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Apr 4, 2017 at 7:22 AM, Ross Burton <ross.burton@intel.com> wrote: > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/classes/sanity.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 94c78b5..ade8cb6 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -589,7 +589,7 @@ def sanity_handle_abichanges(status, d): > with open(abifile, "w") as f: > f.write(current_abi) > elif int(abi) <= 11 and current_abi == "12": > - status.addresult("The layout of TMPDIR changed for Recipe > Specific Sysroots.\nConversion doesn't make sense and this change will > rebuild everything so please start with a clean TMPDIR.\n") > + status.addresult("The layout of TMPDIR changed for Recipe > Specific Sysroots.\nConversion doesn't make sense and this change will > rebuild everything so please start with a clean TMPDIR (%s).\n" % > d.getVar("TMPDIR")) > This looks good, though I wonder if we should explicitly state that it should be removed. I could see someone wondering how they “clean” their tmpdir :) -- Christopher Larson kergoth at gmail dot com Founder - BitBake, OpenEmbedded, OpenZaurus Senior Software Engineer, Mentor Graphics -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 4 April 2017 at 16:13, Christopher Larson <kergoth@gmail.com> wrote: > This looks good, though I wonder if we should explicitly state that it > should be removed. I could see someone wondering how they “clean” their > tmpdir :) > Good point, v2 sent. Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 94c78b5..ade8cb6 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -589,7 +589,7 @@ def sanity_handle_abichanges(status, d): with open(abifile, "w") as f: f.write(current_abi) elif int(abi) <= 11 and current_abi == "12": - status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR.\n") + status.addresult("The layout of TMPDIR changed for Recipe Specific Sysroots.\nConversion doesn't make sense and this change will rebuild everything so please start with a clean TMPDIR (%s).\n" % d.getVar("TMPDIR")) elif (abi != current_abi): # Code to convert from one ABI to another could go here if possible. status.addresult("Error, TMPDIR has changed its layout version number (%s to %s) and you need to either rebuild, revert or adjust it at your own risk.\n" % (abi, current_abi))
Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/classes/sanity.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.8.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core