mbox series

[Linaro-uefi,Linaro-uefi,v3,0/3] D03/D05 platforms bug fix

Message ID 1491827595-84884-1-git-send-email-chenhui.sun@linaro.org
Headers show
Series D03/D05 platforms bug fix | expand

Message

Chenhui Sun April 10, 2017, 12:33 p.m. UTC
ode can also be found in linaro repo:
http://git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
branch: rp-17.04-04

Mainly include
* refine the code style according Leif's comments
* drop the "Hisilicon: Fix ACPI/DSDT table checksum error" path this time,
  and will send out after ERP17.04 

Chenhui Sun (2):
  Hisilicon: disable RC Option Rom
  Hisilicon: Add reconfig lane number feature

shaochangliang (1):
  Hisilicon/PCIe: Fix the probability of I350 enumeration fail issue.

 .../Hi1610/Drivers/PcieInit1610/PcieInitLib.c      | 184 ++++++++++++++++++++-
 .../Hi1610/Drivers/PcieInit1610/PcieInitLib.h      |   4 +
 Chips/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h |   5 +
 3 files changed, 191 insertions(+), 2 deletions(-)

Comments

Leif Lindholm April 10, 2017, 2:12 p.m. UTC | #1
On Mon, Apr 10, 2017 at 08:33:12PM +0800, Chenhui Sun wrote:
> ode can also be found in linaro repo:
> http://git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
> branch: rp-17.04-04
> 

I'm happy with these patches, but am currently having some issues with
git.linaro.org. Will push as soon as possible.


> Mainly include
> * refine the code style according Leif's comments
> * drop the "Hisilicon: Fix ACPI/DSDT table checksum error" path this time,
>   and will send out after ERP17.04 

I don't think the changes required for the checksum patch are very
substantial, and it is an important fix. Can you try to get a new
version out based on my feedback? (Or are there additional technical
issues as well?)

Regards,

Leif

> 
> Chenhui Sun (2):
>   Hisilicon: disable RC Option Rom
>   Hisilicon: Add reconfig lane number feature
> 
> shaochangliang (1):
>   Hisilicon/PCIe: Fix the probability of I350 enumeration fail issue.
> 
>  .../Hi1610/Drivers/PcieInit1610/PcieInitLib.c      | 184 ++++++++++++++++++++-
>  .../Hi1610/Drivers/PcieInit1610/PcieInitLib.h      |   4 +
>  Chips/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h |   5 +
>  3 files changed, 191 insertions(+), 2 deletions(-)
> 
> -- 
> 1.9.1
>
Leif Lindholm April 10, 2017, 3:18 p.m. UTC | #2
On Mon, Apr 10, 2017 at 08:33:12PM +0800, Chenhui Sun wrote:
> ode can also be found in linaro repo:
> http://git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
> branch: rp-17.04-04

Git issues resolved, pushed as bd9bf1d..25d6112.

> Mainly include
> * refine the code style according Leif's comments
> * drop the "Hisilicon: Fix ACPI/DSDT table checksum error" path this time,
>   and will send out after ERP17.04 
> 
> Chenhui Sun (2):
>   Hisilicon: disable RC Option Rom
>   Hisilicon: Add reconfig lane number feature
> 
> shaochangliang (1):
>   Hisilicon/PCIe: Fix the probability of I350 enumeration fail issue.
> 
>  .../Hi1610/Drivers/PcieInit1610/PcieInitLib.c      | 184 ++++++++++++++++++++-
>  .../Hi1610/Drivers/PcieInit1610/PcieInitLib.h      |   4 +
>  Chips/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h |   5 +
>  3 files changed, 191 insertions(+), 2 deletions(-)
> 
> -- 
> 1.9.1
>
Chenhui Sun April 11, 2017, 1:21 a.m. UTC | #3
Hi Leif,


在 2017/4/10 22:12, Leif Lindholm 写道:
> On Mon, Apr 10, 2017 at 08:33:12PM +0800, Chenhui Sun wrote:
>> ode can also be found in linaro repo:
>> http://git.linaro.org/people/heyi.guo/OpenPlatformPkg.git
>> branch: rp-17.04-04
>>
> I'm happy with these patches, but am currently having some issues with
> git.linaro.org. Will push as soon as possible.
>
>
>> Mainly include
>> * refine the code style according Leif's comments
>> * drop the "Hisilicon: Fix ACPI/DSDT table checksum error" path this time,
>>    and will send out after ERP17.04
> I don't think the changes required for the checksum patch are very
> substantial, and it is an important fix. Can you try to get a new
> version out based on my feedback? (Or are there additional technical
> issues as well?)
Sorry for missing your previous comments, will send out the updated 
version today, no technical issues here.

Thanks and Regards
Chenhui

> Regards,
>
> Leif
>
>> Chenhui Sun (2):
>>    Hisilicon: disable RC Option Rom
>>    Hisilicon: Add reconfig lane number feature
>>
>> shaochangliang (1):
>>    Hisilicon/PCIe: Fix the probability of I350 enumeration fail issue.
>>
>>   .../Hi1610/Drivers/PcieInit1610/PcieInitLib.c      | 184 ++++++++++++++++++++-
>>   .../Hi1610/Drivers/PcieInit1610/PcieInitLib.h      |   4 +
>>   Chips/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h |   5 +
>>   3 files changed, 191 insertions(+), 2 deletions(-)
>>
>> -- 
>> 1.9.1
>>