From patchwork Mon Sep 19 17:16:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 76566 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp1070989qgf; Mon, 19 Sep 2016 10:17:03 -0700 (PDT) X-Received: by 10.107.8.42 with SMTP id 42mr36751254ioi.144.1474305422993; Mon, 19 Sep 2016 10:17:02 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 20si27118891itl.6.2016.09.19.10.17.02; Mon, 19 Sep 2016 10:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 770C260DE7; Mon, 19 Sep 2016 17:17:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 02F8760E8F; Mon, 19 Sep 2016 17:16:51 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 96FCA60DD9; Mon, 19 Sep 2016 17:16:45 +0000 (UTC) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by lists.linaro.org (Postfix) with ESMTPS id 9DAAD60DD9 for ; Mon, 19 Sep 2016 17:16:44 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id w84so87528783wmg.1 for ; Mon, 19 Sep 2016 10:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=thNZB+51hdFMV/Ra+PBWYk8S5qHOFHqlgjdsF7GtoEE=; b=UvllIgdRcR4KF1bCHA247YQMzk7ZxKdaTRSxrKWn77jOr+77tDsXpgzCqz3OAIg70I hlPunJnd8yvAYBCfYMApK1jUqaYlFNIEnZRaZVa3WyxHRHu+nqi0VH7b8117O3EnEJeT kt5fDOWrNon1bpt6qF8dF1GdKf7iZ5tByU27sET3N4suGDjNJezGNo1TOX7FY3Txw2dp jp02hLnDoePX7MzkWm0RhmbNHuGCBrDP+yWR5oMh5qhy/9BDJcQzv/Y5n88s7MggSot0 f946aQ7KxeotrXZ5K81aoufUn3wK0tLe3T8fCKkW0kvoqsMJyXDddDV/TLJiU2VT2He0 Azbg== X-Gm-Message-State: AE9vXwMOjBum/hFMF+nyB0MU0bpqYnm46ykB4tWgkO+ci1mfYcv/PeICT0iYDSjj8Fh2gv6OVJo= X-Received: by 10.194.142.244 with SMTP id rz20mr11876616wjb.69.1474305403624; Mon, 19 Sep 2016 10:16:43 -0700 (PDT) Received: from localhost.localdomain ([160.171.69.147]) by smtp.gmail.com with ESMTPSA id m5sm25445980wmd.1.2016.09.19.10.16.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Sep 2016 10:16:42 -0700 (PDT) From: Ard Biesheuvel To: linaro-uefi@lists.linaro.org Date: Mon, 19 Sep 2016 18:16:36 +0100 Message-Id: <1474305396-18809-2-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474305396-18809-1-git-send-email-ard.biesheuvel@linaro.org> References: <1474305396-18809-1-git-send-email-ard.biesheuvel@linaro.org> Subject: [Linaro-uefi] [PATCH v2 2/2] Platforms/AMD/Styx: use anonymous return values for I2Cn::SSCN/FMCN X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" The compiler complains about the named objects used to hold the return values of the I2C0 and I2C1 SSCN and FMCN methods: Method (SSCN, 0, NotSerialized) Control Method should be made Serialized ^ (due to creation of named objects within) Method (FMCN, 0, NotSerialized) Control Method should be made Serialized ^ (due to creation of named objects within) So return anonymous rather than named packages to shut up the compiler diagnostic. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Acked-by: Graeme Gregory --- v2: new patch Platforms/AMD/Styx/AcpiTables/Dsdt.asl | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl index 554cb8738529..4e80e4e59547 100644 --- a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl +++ b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl @@ -397,24 +397,22 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3) Method (SSCN, 0, NotSerialized) { - Name (PKG, Package (0x03) + Return (Package (0x03) { 0x0430, 0x04E1, 0x00 }) - Return (PKG) } Method (FMCN, 0, NotSerialized) { - Name (PKG, Package (0x03) + Return (Package (0x03) { 0x00DE, 0x018F, 0x00 }) - Return (PKG) } } @@ -433,24 +431,22 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3) Method (SSCN, 0, NotSerialized) { - Name (PKG, Package (0x03) + Return (Package (0x03) { 0x0430, 0x04E1, 0x00 }) - Return (PKG) } Method (FMCN, 0, NotSerialized) { - Name (PKG, Package (0x03) + Return (Package (0x03) { 0x00DE, 0x018F, 0x00 }) - Return (PKG) } }