From patchwork Tue Jan 3 12:21:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 89647 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp7977614qgi; Tue, 3 Jan 2017 04:21:56 -0800 (PST) X-Received: by 10.237.45.38 with SMTP id h35mr65393377qtd.9.1483446116117; Tue, 03 Jan 2017 04:21:56 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id l2si24596940qta.190.2017.01.03.04.21.55; Tue, 03 Jan 2017 04:21:56 -0800 (PST) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id BBBF660C32; Tue, 3 Jan 2017 12:21:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id C28BA60BF6; Tue, 3 Jan 2017 12:21:28 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 54666608C2; Tue, 3 Jan 2017 12:21:22 +0000 (UTC) Received: from mail-wj0-f181.google.com (mail-wj0-f181.google.com [209.85.210.181]) by lists.linaro.org (Postfix) with ESMTPS id 839D160849 for ; Tue, 3 Jan 2017 12:21:20 +0000 (UTC) Received: by mail-wj0-f181.google.com with SMTP id tq7so206595720wjb.0 for ; Tue, 03 Jan 2017 04:21:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=705LOX+m+JRckGq1EbqkMZKTTZbNtAtcSLRmSkdBa2g=; b=spYmtCa4bWwgIPZBo9U6yjiAP/AENzy0lonaFERZpUKVSfFX6V/igRmJFx4L57hDr4 g06mFUNa1rjZxVuGt1ENJfejoUUk5CNfu6DD+G1/KxQhPmMF3wVLVEFSHgId96JuEKV8 18+r7w/P0hTxB+7SmHet1w715K3l2HNZuE8cvMy0KGPgkApthD0QdCbQqoteRqOY/Jqq eIuLoxzi+Ni+fDicLOjHVgT5oAE5iJBV+n2A3uyTdK0tTTHjOUs3ndfeb7LkKqNcNyb0 32VA3MK1JY2ZNZXEj4BEk54Wqd0HVrUnYZwnjHleZcMzBebxHq/32MezHtJFzUDq57pU 1DoQ== X-Gm-Message-State: AIkVDXKMW0cMhnNrXJkwX5kz6zR72j/S31SHGC5zQWXjd8VqtjZgX2YjFdzN2tPzVHR8vx16CaI= X-Received: by 10.194.96.135 with SMTP id ds7mr53213720wjb.29.1483446079350; Tue, 03 Jan 2017 04:21:19 -0800 (PST) Received: from mohikan.hemma.eciton.net ([2a01:348:6:8735:e23f:49ff:fe6d:9d26]) by smtp.gmail.com with ESMTPSA id g184sm89236529wme.23.2017.01.03.04.21.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2017 04:21:18 -0800 (PST) From: Leif Lindholm To: devel@acpica.org Date: Tue, 3 Jan 2017 12:21:16 +0000 Message-Id: <20170103122116.27358-2-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170103122116.27358-1-leif.lindholm@linaro.org> References: <20170103122116.27358-1-leif.lindholm@linaro.org> Cc: linaro-uefi@lists.linaro.org, Lv Zheng , linaro-acpi@lists.linaro.org Subject: [Linaro-uefi] [PATCH v2] EFI: fix build for AARCH64 X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" AARCH64 build was left out of initial version, so add to .dsc and set ACPI_MACHINE_WIDTH correctly. Also, acpidump.inf specified explicit per-architecture (but identical) CFLAGS. Rather than duplicating this further, use the same setting for all architectures until there is actually a need to diverge. Also update README to make it obvious AArch64 is supported. Signed-off-by: Leif Lindholm --- v2 contains a fix for a non-functional issue, which could generate warnings when building with CLANG. generate/efi/AcpiPkg.dsc | 2 +- generate/efi/README | 1 + generate/efi/acpidump/acpidump.inf | 6 ++---- source/include/platform/acefi.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/generate/efi/AcpiPkg.dsc b/generate/efi/AcpiPkg.dsc index 323d39c..9302555 100644 --- a/generate/efi/AcpiPkg.dsc +++ b/generate/efi/AcpiPkg.dsc @@ -18,7 +18,7 @@ PLATFORM_VERSION = 1.0 DSC_SPECIFICATION = 0x00010005 OUTPUT_DIRECTORY = Build/Acpi - SUPPORTED_ARCHITECTURES = IA32|X64 + SUPPORTED_ARCHITECTURES = AARCH64|IA32|X64 BUILD_TARGETS = DEBUG|RELEASE SKUID_IDENTIFIER = DEFAULT diff --git a/generate/efi/README b/generate/efi/README index 7550e9d..b3ec3ff 100644 --- a/generate/efi/README +++ b/generate/efi/README @@ -20,6 +20,7 @@ But the porting has only been tested in a Linux environment. You can find built EFI binaries (e.x., acpidump.efi) in the following folders: + Build/Acpi/DEBUG_GCC47/AARCH64: aarch64 targets Build/Acpi/DEBUG_GCC47/IA32: i386 targets Build/Acpi/DEBUG_GCC47/X64: x86_64 targets diff --git a/generate/efi/acpidump/acpidump.inf b/generate/efi/acpidump/acpidump.inf index 8d2c979..e5f21c0 100644 --- a/generate/efi/acpidump/acpidump.inf +++ b/generate/efi/acpidump/acpidump.inf @@ -55,7 +55,5 @@ BaseLib [BuildOptions] - MSFT:*_*_IA32_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP - MSFT:*_*_X64_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP - GCC:*_*_IA32_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include - GCC:*_*_X64_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include + MSFT:*_*_*_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP + GCC:*_*_*_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include diff --git a/source/include/platform/acefi.h b/source/include/platform/acefi.h index 8328ab6..75ef89a 100644 --- a/source/include/platform/acefi.h +++ b/source/include/platform/acefi.h @@ -140,7 +140,7 @@ #define VOID void -#if defined(__ia64__) || defined(__x86_64__) +#if defined(__aarch64__) || defined(__ia64__) || defined(__x86_64__) #define ACPI_MACHINE_WIDTH 64