| Message ID | 1611944866-29373-1-git-send-email-spujar@nvidia.com |
|---|---|
| Headers | show |
| Series | Tegra186 and Tegra194 audio graph card | expand |
On Fri, 29 Jan 2021 23:57:37 +0530, Sameer Pujar wrote: > This series adds support for audio graph based solution on Tegra186 and > Tegra194. This enables audio paths for I2S, DMIC and DSPK modules. > > Depending on the platform Jetson TX2 or Jetson AGX Xavier, required I/O > module instances are enabled. Since the latter board has on board audio > codec, DT support for the same is enabled and external audio playback and > capture can be used. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/9] ASoC: dt-bindings: rt5659: Update binding doc commit: 6bbb859012e905736c852b518be16c653e451967 [2/9] ASoC: dt-bindings: tegra: Add iommus property to Tegra graph card commit: 70f0bc65f6cf757fa4cca2d6fcb84f613bc0d8cc [3/9] ASoC: audio-graph-card: Add clocks property to endpoint node commit: 531e5b7abbde3c190aeff5b13c17f7ef3e0f3543 [4/9] ASoC: rt5659: Add Kconfig prompt commit: 563c2681d4313f55b9b1d9a8f635946cd4972170 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Fri, Jan 29, 2021 at 11:57:38PM +0530, Sameer Pujar wrote: > Update following in rt5659.txt binding doc > - Add JD source for Intel HDA header: Commit 041e74b71491 > ("ASoC: rt5659: Add the support of Intel HDA Header") > added driver support. Add missing info here. > > - sound-name-prefix: Used to prefix component widgets/kcontrols > with given prefix. > > - ports: Helps to use the Codec with audio graph card > > Signed-off-by: Sameer Pujar <spujar@nvidia.com> > Reported-by: Jon Hunter <jonathanh@nvidia.com> > Cc: Oder Chiou <oder_chiou@realtek.com> > Cc: Bard Liao <bardliao@realtek.com> > --- > Documentation/devicetree/bindings/sound/rt5659.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt > index 56788f5..c473df5 100644 > --- a/Documentation/devicetree/bindings/sound/rt5659.txt > +++ b/Documentation/devicetree/bindings/sound/rt5659.txt > @@ -37,10 +37,21 @@ Optional properties: > - realtek,jd-src > 0: No JD is used > 1: using JD3 as JD source > + 2: JD source for Intel HDA header > > - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. > - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. > > +- sound-name-prefix: Please refer to name-prefix.txt > + > +- ports: A Codec may have a single or multiple I2S interfaces. These > + interfaces on Codec side can be described under 'ports' or 'port'. > + When the SoC or host device is connected to multiple interfaces of > + the Codec, the connectivity can be described using 'ports' property. > + If a single interface is used, then 'port' can be used. The usage > + depends on the platform or board design. > + Please refer to Documentation/devicetree/bindings/graph.txt Please read what that file says now. > + > Pins on the device (for linking into audio routes) for RT5659/RT5658: > > * DMIC L1 > -- > 2.7.4 >
Hi Rob, On 2/5/2021 8:59 PM, Rob Herring wrote: > External email: Use caution opening links or attachments > > > On Fri, Jan 29, 2021 at 11:57:38PM +0530, Sameer Pujar wrote: >> Update following in rt5659.txt binding doc >> - Add JD source for Intel HDA header: Commit 041e74b71491 >> ("ASoC: rt5659: Add the support of Intel HDA Header") >> added driver support. Add missing info here. >> >> - sound-name-prefix: Used to prefix component widgets/kcontrols >> with given prefix. >> >> - ports: Helps to use the Codec with audio graph card >> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >> Reported-by: Jon Hunter <jonathanh@nvidia.com> >> Cc: Oder Chiou <oder_chiou@realtek.com> >> Cc: Bard Liao <bardliao@realtek.com> >> --- >> Documentation/devicetree/bindings/sound/rt5659.txt | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt >> index 56788f5..c473df5 100644 >> --- a/Documentation/devicetree/bindings/sound/rt5659.txt >> +++ b/Documentation/devicetree/bindings/sound/rt5659.txt >> @@ -37,10 +37,21 @@ Optional properties: >> - realtek,jd-src >> 0: No JD is used >> 1: using JD3 as JD source >> + 2: JD source for Intel HDA header >> >> - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. >> - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. >> >> +- sound-name-prefix: Please refer to name-prefix.txt >> + >> +- ports: A Codec may have a single or multiple I2S interfaces. These >> + interfaces on Codec side can be described under 'ports' or 'port'. >> + When the SoC or host device is connected to multiple interfaces of >> + the Codec, the connectivity can be described using 'ports' property. >> + If a single interface is used, then 'port' can be used. The usage >> + depends on the platform or board design. >> + Please refer to Documentation/devicetree/bindings/graph.txt > Please read what that file says now. Sorry, I did not understand above comment. Can you please elaborate a bit more?
On 2/10/2021 12:49 AM, Thierry Reding wrote: > On Tue, Feb 09, 2021 at 06:51:58PM +0530, Sameer Pujar wrote: >> Hi Rob, >> >> On 2/5/2021 8:59 PM, Rob Herring wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On Fri, Jan 29, 2021 at 11:57:38PM +0530, Sameer Pujar wrote: >>>> Update following in rt5659.txt binding doc >>>> - Add JD source for Intel HDA header: Commit 041e74b71491 >>>> ("ASoC: rt5659: Add the support of Intel HDA Header") >>>> added driver support. Add missing info here. >>>> >>>> - sound-name-prefix: Used to prefix component widgets/kcontrols >>>> with given prefix. >>>> >>>> - ports: Helps to use the Codec with audio graph card >>>> >>>> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >>>> Reported-by: Jon Hunter <jonathanh@nvidia.com> >>>> Cc: Oder Chiou <oder_chiou@realtek.com> >>>> Cc: Bard Liao <bardliao@realtek.com> >>>> --- >>>> Documentation/devicetree/bindings/sound/rt5659.txt | 11 +++++++++++ >>>> 1 file changed, 11 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt >>>> index 56788f5..c473df5 100644 >>>> --- a/Documentation/devicetree/bindings/sound/rt5659.txt >>>> +++ b/Documentation/devicetree/bindings/sound/rt5659.txt >>>> @@ -37,10 +37,21 @@ Optional properties: >>>> - realtek,jd-src >>>> 0: No JD is used >>>> 1: using JD3 as JD source >>>> + 2: JD source for Intel HDA header >>>> >>>> - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. >>>> - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. >>>> >>>> +- sound-name-prefix: Please refer to name-prefix.txt >>>> + >>>> +- ports: A Codec may have a single or multiple I2S interfaces. These >>>> + interfaces on Codec side can be described under 'ports' or 'port'. >>>> + When the SoC or host device is connected to multiple interfaces of >>>> + the Codec, the connectivity can be described using 'ports' property. >>>> + If a single interface is used, then 'port' can be used. The usage >>>> + depends on the platform or board design. >>>> + Please refer to Documentation/devicetree/bindings/graph.txt >>> Please read what that file says now. >> Sorry, I did not understand above comment. Can you please elaborate a bit >> more? > I think what Rob meant to point out is that graph.txt now contains a > mention that the file has been moved to a more central location, which > is the dt-schema repository. So instead of referencing the graph.txt, > which then redirects to the graph.yaml in dt-schema, it'd be better to > directly reference graph.yaml from dt-schema. > > That said, I'm not aware of a good or standard way to make such a > reference. Perhaps in this case, given that the rt5659 binding is not > very large, you can convert the file to json-schema first and then use > standard json-schema references for this. OK, in that case I will try convert this binding to json-schema in a separate patch. Thanks.
This series adds support for audio graph based solution on Tegra186 and Tegra194. This enables audio paths for I2S, DMIC and DSPK modules. Depending on the platform Jetson TX2 or Jetson AGX Xavier, required I/O module instances are enabled. Since the latter board has on board audio codec, DT support for the same is enabled and external audio playback and capture can be used. Changelog ========= v1 --> v2: ---------- - Dropped patch "ASoC: tegra: Select SND_SOC_RT5659" as per suggestion from Mark. - Add new patch "ASoC: rt5659: Add Kconfig prompt" - Add new patch "arm64: defconfig: Enable RT5659" - No changes in other patches from earlier series. Sameer Pujar (9): ASoC: dt-bindings: rt5659: Update binding doc ASoC: dt-bindings: tegra: Add iommus property to Tegra graph card ASoC: audio-graph-card: Add clocks property to endpoint node ASoC: rt5659: Add Kconfig prompt arm64: defconfig: Enable RT5659 arm64: tegra: Add RT5658 device entry Revert "arm64: tegra: Disable the ACONNECT for Jetson TX2" arm64: tegra: Audio graph sound card for Jetson TX2 arm64: tegra: Audio graph sound card for Jetson AGX Xavier .../bindings/sound/audio-graph-port.yaml | 3 + .../sound/nvidia,tegra-audio-graph-card.yaml | 3 + Documentation/devicetree/bindings/sound/rt5659.txt | 11 + arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 609 +++++++++++++++++++++ arch/arm64/boot/dts/nvidia/tegra186.dtsi | 22 + arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 468 ++++++++++++++++ arch/arm64/boot/dts/nvidia/tegra194.dtsi | 20 + arch/arm64/configs/defconfig | 1 + sound/soc/codecs/Kconfig | 2 +- 9 files changed, 1138 insertions(+), 1 deletion(-)