| Message ID | 20200921110814.2910477-1-kai.vehmanen@linux.intel.com |
|---|---|
| Headers | show |
| Series | ASoC: SOF: fix kcontrol size checks | expand |
On Mon, 21 Sep 2020 14:08:09 +0300, Kai Vehmanen wrote: > Series that fixes checks for 'size' in kcontrol get/put ext_bytes methods > for SOF. The gaps in these checks were discovered via cppcheck warnings > on unused variable values. > > Pierre-Louis Bossart (5): > ASoC: SOF: control: fix size checks for ext_bytes control .get() > ASoC: SOF: control: fix size checks for volatile ext_bytes control > .get() > ASoC: SOF: control: add size checks for ext_bytes control .put() > ASoC: SOF: control: remove const in sizeof() > ASoC: SOF: topology: remove const in sizeof() > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: SOF: control: fix size checks for ext_bytes control .get() commit: 3331bcd6a2f2dbe9c1fa764df695422c99e2f1fb [2/5] ASoC: SOF: control: fix size checks for volatile ext_bytes control .get() commit: ec5a97624a8de4f44b090cf53bd48c05458e0b17 [3/5] ASoC: SOF: control: add size checks for ext_bytes control .put() commit: 2ca210112ad91880d2d5a3f85fecc838600afbce [4/5] ASoC: SOF: control: remove const in sizeof() (no commit info) [5/5] ASoC: SOF: topology: remove const in sizeof() (no commit info) All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi Mark, On Tue, 22 Sep 2020, Mark Brown wrote: > [3/5] ASoC: SOF: control: add size checks for ext_bytes control .put() > commit: 2ca210112ad91880d2d5a3f85fecc838600afbce > [4/5] ASoC: SOF: control: remove const in sizeof() > (no commit info) > [5/5] ASoC: SOF: topology: remove const in sizeof() > (no commit info) [...] > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next I wonder what happened here...? Patches 4 and 5 didn't end up applied although they were in the sent series. I can send them again no prob, but wondering if there was something wrong in the original series, so I can avoid the problem in the future. Br, Kai
On Thu, Sep 24, 2020 at 02:30:23PM +0300, Kai Vehmanen wrote: > On Thu, 24 Sep 2020, Mark Brown wrote: > > Do those patches actually apply to for-5.10 or are they correcting > > issues that only exist in for-5.9? > yes, the series was based on broonie/for-5.10 for sending, and I tested > again and both of the dropped patches still apply on top of for-5.10. They > do not apply cleanly on top of for-5.9. Well, that's the only thing I can think of - that git thought they didn't actaully have any changes in them when it tried to apply them.
Series that fixes checks for 'size' in kcontrol get/put ext_bytes methods for SOF. The gaps in these checks were discovered via cppcheck warnings on unused variable values. Pierre-Louis Bossart (5): ASoC: SOF: control: fix size checks for ext_bytes control .get() ASoC: SOF: control: fix size checks for volatile ext_bytes control .get() ASoC: SOF: control: add size checks for ext_bytes control .put() ASoC: SOF: control: remove const in sizeof() ASoC: SOF: topology: remove const in sizeof() sound/soc/sof/control.c | 53 +++++++++++++++++++++++++++++++--------- sound/soc/sof/topology.c | 2 +- 2 files changed, 43 insertions(+), 12 deletions(-)