mbox series

[v2,0/7] ASoC: codecs: add support for LPASS Codec TX and RX macros

Message ID 20210208141719.23305-1-srinivas.kandagatla@linaro.org
Headers show
Series ASoC: codecs: add support for LPASS Codec TX and RX macros | expand

Message

Srinivas Kandagatla Feb. 8, 2021, 2:17 p.m. UTC 
Thanks for reviewing v1, here is v2 patchset addressing comments from v1.

This patchset adds support for two Codec Macro blocks(TX and RX) available in
Qualcomm LPASS (Low Power Audio SubSystem).

There are WSA, VA, TX and RX Macros on LPASS IP, each of the Macro block
has specific connectivity like WSA Macros are intended to connect
to WSA Smart speaker codecs via SoundWire. VA Macro is intended for DMICs,
and TX/RX for Analog codecs via SoundWire like other WCD938x Codecs to provide
headphone/ear/lineout/amic/dmic etc ..

Most of the work is derived from downstream Qualcomm kernels.
Credits to various Qualcomm authors from Patrick Lai's team who have
contributed to this code.

This patchset has been tested on support to SM8250 MTP Development Board.
This board has 2 WSA881X smart speakers with onboard DMIC connected to
internal LPASS codec via WSA  and VA macros respectively and WCD938x
TX and RX connected via Soundwire via TX and RX Macros reseptively.

Thanks,
srini

Changes since v1
	- make copyright header line with C++ one
	- correct usage of regcache!
	- moved ON/OFF enums to proper switch controls
	- Align all the control naming!
	- inline swrm_clock function.

Srinivas Kandagatla (7):
  ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec
  ASoC: codec: lpass-rx-macro: add support for lpass rx macro
  ASoC: codec: lpass-rx-macro: add dapm widgets and route
  ASoC: codec: lpass-rx-macro: add iir widgets
  ASoC: qcom: dt-bindings: add bindings for lpass tx macro codec
  ASoC: codec: lpass-tx-macro: add support for lpass tx macro
  ASoC: codec: lpass-tx-macro: add dapm widgets and route

 .../bindings/sound/qcom,lpass-rx-macro.yaml   |   62 +
 .../bindings/sound/qcom,lpass-tx-macro.yaml   |   67 +
 sound/soc/codecs/Kconfig                      |   10 +
 sound/soc/codecs/Makefile                     |    4 +
 sound/soc/codecs/lpass-rx-macro.c             | 3604 +++++++++++++++++
 sound/soc/codecs/lpass-tx-macro.c             | 1877 +++++++++
 6 files changed, 5624 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
 create mode 100644 sound/soc/codecs/lpass-rx-macro.c
 create mode 100644 sound/soc/codecs/lpass-tx-macro.c

Comments

Srinivas Kandagatla Feb. 8, 2021, 4:17 p.m. UTC | #1 
On 08/02/2021 16:08, Mark Brown wrote:
>> +	SOC_SINGLE_EXT("RX_Softclip Enable", SND_SOC_NOPM, 0, 1, 0,
>> +		     rx_macro_soft_clip_enable_get,
>> +		     rx_macro_soft_clip_enable_put),
>> +	SOC_SINGLE_EXT("AUX_HPF Enable", SND_SOC_NOPM, 0, 1, 0,
>> +			rx_macro_aux_hpf_mode_get,
>> +			rx_macro_aux_hpf_mode_put),
> These are simple on/off controls so should end in Switch AFAICT.

Yes it makes sense!
> Otherwise this looks good.
Thanks, will fix this and send a new version!

--srini