| Message ID | 20230523213825.120077-1-macroalpha82@gmail.com |
|---|---|
| Headers | show |
| Series | Add Support for RK3588s Indiedroid Nova | expand |
On Tue, May 23, 2023 at 04:38:20PM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Enable support for 12Mhz sysclk on es8328. This sysclk value is used on > the Indiedroid Nova rk3588s based single board computer. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > Signed-off-by: Chris Zhong <zyw@rock-chips.com> If you're sending the patch your signoff should be last in the list.
On Wed, May 24, 2023 at 11:12:49AM -0500, Chris Morgan wrote: > On Wed, May 24, 2023 at 12:57:02PM +0100, Mark Brown wrote: > > The other constraints have separate rates and ratios, with wildly > > different values between the two - the ratio (I'm guessing a clock > > divider) being written to a 5 bit field which obviously can't contain > > the actual sample rate. > A bit over my head here, I saw this patch from the Rockchip BSP kernel > branch and tested it on my mainline kernel. Long story short the clock > for the mclk is 12000000. I see that there are similar issues for the > ES8316 on the Rock 5B, so I will probably just wait for a proper fix > there and then implement something similar here. It sounded from the rest of the series like you don't actually want to run at 12MHz anyway, you want a change which deconfigures the sysclk when the card is idle - that'd allow it to be reconfigured as needed to support the widest possible set of rates. That'd be work in the generic cards.
On Tue, May 23, 2023 at 04:38:24PM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add Indiedroid Nova, an rk3588s based single board computer. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
From: Chris Morgan <macromorgan@hotmail.com> Add support for the RK3588s based Indiedroid Nova. Note that this series is dependent on regulator support for the RK806 being upstreamed. https://lore.kernel.org/linux-rockchip/20230515152044.GT10825@google.com/ Chris Morgan (6): ASoC: es8328: Enabling support for 12Mhz sysclk arm64: dts: rockchip: add default pinctrl for rk3588 emmc arm64: dts: rockchip: Add sdio node to rk3588 dt-bindings: vendor-prefixes: add Indiedroid dt-bindings: arm: rockchip: Add Indiedroid Nova arm64: dts: rockchip: Add Indiedroid Nova board .../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3588s-indiedroid-nova.dts | 761 ++++++++++++++++++ arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 18 + sound/soc/codecs/es8328.c | 17 + 6 files changed, 804 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts