mbox series

[0/4] ALSA: hda: Abstract and update HOST-stream setup procedure

Message ID 20230925115844.18795-1-cezary.rojewski@intel.com
Headers show
Series ALSA: hda: Abstract and update HOST-stream setup procedure | expand

Message

Cezary Rojewski Sept. 25, 2023, 11:58 a.m. UTC 
The patchset targets two intertwined topics:

The driver shall poll SDxFIFOS to ensure a valid value is set by the
controller after programming SDxFMT. Due to amount of users and
limited-number of configuration available in our CI when compared to
overall possibilities on the market, the check is non-blocking.

Second topic relates to stream setup procedure. The procedure differs
between HDAudio controller device revisions. Right now those differences
are handled directly by a platform driver. Existing top-level
'if (pci->device == APL)' could be replaced by a abstraction in lower
parts of the code instead.

With that done, the two users are updated accordingly. In avs-driver
case, this updates the flow to the recommended one.

Cezary Rojewski (4):
  ALSA: hda: Poll SDxFIFOS after programming SDxFMT
  ALSA: hda: Introduce HOST stream setup mechanism
  ASoC: Intel: avs: Use helper to setup HOST stream
  ASoC: Intel: Skylake: Use helper to setup HOST stream

 include/sound/hda_register.h      |  2 ++
 include/sound/hdaudio.h           |  3 +++
 include/sound/hdaudio_ext.h       |  3 +++
 sound/hda/ext/hdac_ext_stream.c   | 41 +++++++++++++++++++++++++++++++
 sound/hda/hdac_stream.c           |  8 ++++++
 sound/soc/intel/avs/pcm.c         |  2 +-
 sound/soc/intel/skylake/skl-pcm.c | 14 +----------
 7 files changed, 59 insertions(+), 14 deletions(-)

Comments

Mark Brown Sept. 25, 2023, 12:28 p.m. UTC | #1 
On Mon, Sep 25, 2023 at 01:58:44PM +0200, Cezary Rojewski wrote:
> snd_hdac_ext_host_stream_setup() abstracts the procedure details away.
> Simplify the code by using it.

Acked-by: Mark Brown <broonie@kernel.org>