mbox series

[V0,0/1] ASoC: soc-compress: Fix and add missing DPCM locking

Message ID cover.1709720380.git.quic_c_shalma@quicinc.com
Headers show
Series ASoC: soc-compress: Fix and add missing DPCM locking | expand

Message

Shalini Manjunatha March 6, 2024, 10:53 a.m. UTC 
We find mising DPCM locking inside soc_compr_set_params_fe()
before calling dpcm_be_dai_hw_params() and dpcm_be_dai_prepare()
which cause lockdep assert for DPCM lock not held in
__soc_pcm_hw_params() and __soc_pcm_prepare() in above flow
when ever we play compress offload audio playback use case.

To fix this issue added DPCM lock and unlock in both places of
above code flow mentioned.

Shalini Manjunatha (1):
  ASoC: soc-compress: Fix and add DPCM locking

 sound/soc/soc-compress.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Mark Brown March 18, 2024, 5:05 p.m. UTC | #1 
On Wed, 06 Mar 2024 16:23:19 +0530, Shalini Manjunatha wrote:
> We find mising DPCM locking inside soc_compr_set_params_fe()
> before calling dpcm_be_dai_hw_params() and dpcm_be_dai_prepare()
> which cause lockdep assert for DPCM lock not held in
> __soc_pcm_hw_params() and __soc_pcm_prepare() in above flow
> when ever we play compress offload audio playback use case.
> 
> To fix this issue added DPCM lock and unlock in both places of
> above code flow mentioned.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-compress: Fix and add DPCM locking
      commit: 9a8b202f8cb7ebebc71f1f2a353a21c76d3063a8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark