From patchwork Wed Mar 6 10:53:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shalini Manjunatha X-Patchwork-Id: 780089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 298AAC54E41 for ; Sat, 9 Mar 2024 10:17:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5B75314E2; Sat, 9 Mar 2024 11:17:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5B75314E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1709979432; bh=un6WSCrH0nwZRCvTfsywl316B66p1DBPStSLUvF7JXU=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=O0sSKkVGSBYNxhkgSchU2QbPBQcQOpNznwYWGbny8I6eXDf8D6ecgzrm5hoqiDP3I g4IlwUakYFnYnEcCn6yZ0SjGvBpbaZof1AsrA/RyeZnMyHiT4OYzBvahlT4PAVXhK4 NKglw2ucgXTVXzK+dPunUPiqYTSCEP2rZyl4dn9g= Received: by alsa1.perex.cz (Postfix, from userid 50401) id AD2B1F80855; Sat, 9 Mar 2024 11:13:20 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6CC7BF80804; Sat, 9 Mar 2024 11:13:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8585DF8024E; Wed, 6 Mar 2024 11:54:22 +0100 (CET) Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D068AF8014B for ; Wed, 6 Mar 2024 11:54:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D068AF8014B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=JA8trjj6 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4268ewkp028060; Wed, 6 Mar 2024 10:54:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id; s=qcppdkim1; bh=5TxhWqAJYi09 OyiGMAl/JFGwe7rxA4G2XCalQeFYGwU=; b=JA8trjj6fAuoQ8I7X9XmYP/VcjEA QjMquurDrnzhKc6NG69xBfR0mCrDhLrdNRvTwFP0QUByqZiOBzH6Thin2NyRw+UI OtHC/eA6T011vev+Gf0uHAM/ho1UQahIWPrcNLPu5a2KOv6l3qk0C1ygLLiGUeVD wX4SWAtb2ijXde3LglpqRveSpDAV54MV9kPSgUpkrJNIx8C2ivGsqblJMoU7X1rC CWtpCAjnfpwEjjKzg6z1iylEQBo5GCXVC+7d7xTfLGYHvSaxhALPaLIFvCREyYU5 AEnwJvcsYT8mi3xWv5WDPsuEX5tWI7Akijuj7ymiIXAD1ubBrRYdx5KTcQ== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wpbav1eu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Mar 2024 10:54:14 +0000 (GMT) Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 426AsA4m018092; Wed, 6 Mar 2024 10:54:10 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 3wkw6ktcbx-1; Wed, 06 Mar 2024 10:54:10 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 426AsAcU018078; Wed, 6 Mar 2024 10:54:10 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-c-shalma-hyd.qualcomm.com [10.213.108.128]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 426AsApF018077; Wed, 06 Mar 2024 10:54:10 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 2341845) id C4DE13E1F; Wed, 6 Mar 2024 16:24:08 +0530 (+0530) From: Shalini Manjunatha To: Vinod Koul , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Raghu Bankapur , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Shalini Manjunatha , linux-kernel@vger.kernel.org Cc: Krishna Jha Subject: [PATCH V0 0/1] ASoC: soc-compress: Fix and add missing DPCM locking Date: Wed, 6 Mar 2024 16:23:19 +0530 Message-Id: X-Mailer: git-send-email 2.7.4 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: OD4E1X52YD1L7EZ0FIIHkkEBesBmaHjP X-Proofpoint-ORIG-GUID: OD4E1X52YD1L7EZ0FIIHkkEBesBmaHjP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-06_06,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=868 impostorscore=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 clxscore=1011 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403060086 X-MailFrom: c_shalma@qualcomm.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: KQ44WJ2IPKGZGYVTS4UI2DOF57253KQA X-Message-ID-Hash: KQ44WJ2IPKGZGYVTS4UI2DOF57253KQA X-Mailman-Approved-At: Sat, 09 Mar 2024 10:11:11 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We find mising DPCM locking inside soc_compr_set_params_fe() before calling dpcm_be_dai_hw_params() and dpcm_be_dai_prepare() which cause lockdep assert for DPCM lock not held in __soc_pcm_hw_params() and __soc_pcm_prepare() in above flow when ever we play compress offload audio playback use case. To fix this issue added DPCM lock and unlock in both places of above code flow mentioned. Shalini Manjunatha (1): ASoC: soc-compress: Fix and add DPCM locking sound/soc/soc-compress.c | 4 ++++ 1 file changed, 4 insertions(+)