From patchwork Wed Mar 11 01:09:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 193344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E73C10F25 for ; Wed, 11 Mar 2020 06:16:16 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1669420873 for ; Wed, 11 Mar 2020 06:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="EodDg/VM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rXZlxFI9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1669420873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 383981612; Wed, 11 Mar 2020 07:15:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 383981612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583907374; bh=QDLDyTPXic3+9x8WuFyWnPrArYTgFychuxvUjipk7Vk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EodDg/VMZctz02CYvraA70gog/MoeySpQqfdyKSGYohLo47uVy5vAEHdMIZQbb0hd lg2uWddF1AKVUU/U4oijpb13GjDLEO6nBFZWIawnrV/0UPdoaGQ1ctC1g5SKQLmqa7 /awBL8Eqxh0IGWYnPa7cU8wm6KbXMzDs0Kg/FR5k= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 68412F80268; Wed, 11 Mar 2020 07:14:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 518BDF8028C; Wed, 11 Mar 2020 02:09:47 +0100 (CET) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CC2BCF80217 for ; Wed, 11 Mar 2020 02:09:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CC2BCF80217 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rXZlxFI9" Received: by mail-wr1-x443.google.com with SMTP id s14so416770wrt.8 for ; Tue, 10 Mar 2020 18:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=00GSpkojnx3B4GB0fFMAKFnU+tANLaiUGZgbkObBjO4=; b=rXZlxFI9JSzCtp81Ib7ST1kaLR/Xl1OrJ2z46XZY4sBTtm3lREyA9akpIS9lcjwiML VYoYR8hLGI5Z+wOOBt7p7W2aTJ/5M/pBoYe0rKUn5gWv3HYP1PSqQSypbszvwaNvmdCz kjTqHgsAfKVBgXFea9cHKcd2aURr8Atn5b94jRSfR4IeSgt6yHXxFVCPCcZVmw1K9fz9 6PLIlVupVklKgjKMLnCPRmPcB5j/UPiF1BKPcq66GPMWM3UkRkJzNucYPExpORpw+xwM miIaPGjeP93ijikHj9Hs7ilF5w2j99rKV3ps+Lp+KmYG9JJjxyFyOcYRjXFKw24fYfoH XE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=00GSpkojnx3B4GB0fFMAKFnU+tANLaiUGZgbkObBjO4=; b=s0yvLOUZwnlKuRVcGd2aYRQZQmpM8ZCWuiff6DPE0gzs27y83k5kVeQSwPP2OaoUZg ZjaGSeT+1RD5jAZojUJWF2EH15cUiAWxcq0UfAeUT4cP/Lt9uMCaz6CPG1qwlzfD/iZ5 jCSOq1lkBTtuvRntpZZNVauhaq2b6RR5RIZcFoYH7UwPF+cPh6qbi/mMLMWjkslEQJ5J U0FVJdj8fz9KMk4HcI9WG3DC0T/P8lVCq7xez8agmS9YNn5L5Ai4jJqCa4nKUr6PK7E3 n0zmCPEkW3wlBMXT6ccRdiDTRMii59Y3oMNrzOyNprcXYy0ti3s8xu8XgggKuGs8g9ZH Bo0g== X-Gm-Message-State: ANhLgQ1YEzpXuAH6IKdFMLlj+w2mwJsUeC8GO/j7rflcK0IC89zxQP2B YKt5cUNt/DEAL/t+uqt2iQ== X-Google-Smtp-Source: ADFU+vuPZB+qEvJlgMjAKNaONJg23VSoTdeJapUHrDxw8mfccmCzR4CYmGDU2ygM1wMZnnyCmheYRQ== X-Received: by 2002:a5d:6902:: with SMTP id t2mr720116wru.135.1583888983726; Tue, 10 Mar 2020 18:09:43 -0700 (PDT) Received: from ninjahost.lan (host-2-102-15-144.as13285.net. [2.102.15.144]) by smtp.googlemail.com with ESMTPSA id i6sm36658097wra.42.2020.03.10.18.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 18:09:43 -0700 (PDT) From: Jules Irenge To: boqun.feng@gmail.com Subject: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Date: Wed, 11 Mar 2020 01:09:08 +0000 Message-Id: <20200311010908.42366-9-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200311010908.42366-1-jbi.octave@gmail.com> References: <0/8> <20200311010908.42366-1-jbi.octave@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 11 Mar 2020 07:14:40 +0100 Cc: "moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET..." , netdev@vger.kernel.org, Takashi Iwai , Clemens Ladisch , linux-kernel@vger.kernel.org, Alexios Zavras , Greg Kroah-Hartman , bpf@vger.kernel.org, Thomas Gleixner , Allison Randal X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Sparse reports a warning at tscm_hwdep_read_locked() warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock The root cause is the missing annotation at tscm_hwdep_read_locked() Add the missing __releases(&tscm->lock) annotation Signed-off-by: Jules Irenge --- sound/firewire/tascam/tascam-hwdep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c index 9801e33e7f2a..6f38335fe10b 100644 --- a/sound/firewire/tascam/tascam-hwdep.c +++ b/sound/firewire/tascam/tascam-hwdep.c @@ -17,6 +17,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf, long count, loff_t *offset) + __releases(&tscm->lock) { struct snd_firewire_event_lock_status event = { .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,