diff mbox series

[v1,3/3] ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()

Message ID 20220124153253.3548853-4-broonie@kernel.org
State Accepted
Commit 4cf28e9ae6e2e11a044be1bcbcfa1b0d8675fe4d
Headers show
Series ASoC: Add bounds checking for written values | expand

Commit Message

Mark Brown Jan. 24, 2022, 3:32 p.m. UTC 
We don't currently validate that the values being set are within the range
we advertised to userspace as being valid, do so and reject any values
that are out of range.

Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
 sound/soc/soc-ops.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c
index c31e63b27193..dc0e7c8d31f3 100644
--- a/sound/soc/soc-ops.c
+++ b/sound/soc/soc-ops.c
@@ -879,6 +879,8 @@  int snd_soc_put_xr_sx(struct snd_kcontrol *kcontrol,
 	long val = ucontrol->value.integer.value[0];
 	unsigned int i;
 
+	if (val < mc->min || val > mc->max)
+		return -EINVAL;
 	if (invert)
 		val = max - val;
 	val &= mask;