From patchwork Mon Aug 5 00:42:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 817086 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F606C3DA7F for ; Mon, 5 Aug 2024 01:06:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78022348C; Mon, 5 Aug 2024 03:01:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78022348C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722819703; bh=1iJwTlDuoNnHR56qO2pl4s2uUPPLG7A151lRy/95UDo=; h=From:Subject:To:Cc:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=lhRE29xQ5Tpc+ZxZGxtA/KNN35atgbDIzOSIA80WOXq18gRc5jJcBS7HHHpHoRI2G GlJiheVD3gxpAMRFf8mavHK71FxvATnsIDwKAlv+9LCQgR3DVf+wftC7xpi3nPn0Ds HZN2e2u49jAR0i8cnPP0GhRuANUF9Eph+XuWBnGk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D558F89D65; Mon, 5 Aug 2024 02:42:41 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2FB95F89D62; Mon, 5 Aug 2024 02:42:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7FFE5F89D36; Mon, 5 Aug 2024 02:42:36 +0200 (CEST) Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazlp170110002.outbound.protection.outlook.com [IPv6:2a01:111:f403:c405::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9D9CDF8070E for ; Mon, 5 Aug 2024 02:42:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D9CDF8070E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=A6xGEXsg ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PJy8oNjawMtxBJhe2GtA2luA32rLdCFPNSpSytabMVhCPEofbAHOxk+oMY99BbzSFmmi7ZQWBATjpsSh5BMzlciSH0i7h6xIbZKCC+A6klXPF7QQzapFlc/jOhOCUi3UdhLVwj9q4g/cD24k44pa73t52ovZwRTOw1wEzDl9U2B4e7cIg1Pc8L4gPWsaDrqcnFKJy6KFQyL46NQbuFi1E9jyRsJeEawuJccg80Y2Mf07e4DMZ35Dtl3OnWnWqFyg4qDIgF+fQH+Uk6KqC/W3KGGdVkps6P6vAtyRVZLXXdaBkW3VbcnkXWZkEk+cAy7BsQxUWXTedyvsEoW1NH+YdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ySU1RJo/vXUmmy68/9s9Q1TsOLxdKsxJuG7unNhgLps=; b=xyODEZ4llP+y4lDHQ0IyMO9Q5ec2dcMqAgPhD1lDhhf3YYv/b+A+TAFfBHhj65/nz02STxRFxv9WEGM5K8Jmd496R6aE5PjqySMNuMHNpm+6RAYpmFtCzRxFb7msbrhAzftxFemNVf3UJxqExP4/xbFDzvihNHxX/Rjs23pifkFcm1BnKMm4ZDU3TNCFZIDSovv0u3jR6qOaE2WMYBBXs9CeZAh8QXsPCjQSLtYKB0pI9EYJDATTOywDJqP2IEXONdc+ZAia70KjthyTfv5KnM5pnG8CnoH88DixU29n1FvjsRntqF9U34QeGI4GX7AISv5ossEzpcbfncoS77qcuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySU1RJo/vXUmmy68/9s9Q1TsOLxdKsxJuG7unNhgLps=; b=A6xGEXsgzLrgdrFUXWNNSE9RffROaJ+tJTrDLWA6/J2tjanpcLdUf4MxQVMb2nPdBI7pwSbPOUB9rv2/xUtIZrjdRDMNTcszf/1L0DHD1blw9YEFeZIM9Ko19ku7ZkBQwCd/BhX0YnMDqJdhZe6p2/skk/sZSaqb2OJNU4m8Evs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by OS3PR01MB9302.jpnprd01.prod.outlook.com (2603:1096:604:1cf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.25; Mon, 5 Aug 2024 00:42:28 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%5]) with mapi id 15.20.7828.023; Mon, 5 Aug 2024 00:42:28 +0000 Message-ID: <87r0b3x0jv.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH 084/113] ASoC: codecs: wl1273: use snd_pcm_is_playback/capture() User-Agent: Wanderlust/2.15.9 Emacs/29.3 Mule/6.0 To: Mark Brown Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, Linux-ALSA In-Reply-To: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> References: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> Date: Mon, 5 Aug 2024 00:42:28 +0000 X-ClientProxiedBy: TYCP286CA0148.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31b::16) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|OS3PR01MB9302:EE_ X-MS-Office365-Filtering-Correlation-Id: cee9efcb-8ad3-4fac-8be0-08dcb4e77bbe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: B1mBWL1eXhrodxWmY0JivuVw3LrWlWHtxSToIkCXMcVcaDHcKdj4ZA9rQ7QPb3DAztXS3pDsloAHLqM+bd5XfrjT6zxTnq8PNJDozawB+N7OgXD26V03rRHOIS9MT361KX/IW14ZQZx2704OfvO9YpuT9VwrzpjbTjDahHXOFODZgVcUSolbBdwZOPSvc9nDHQi7z4jOV4SmBOFFixzj4Wx4qf5LbUx2IQ787gLLqqUPMGuodAyTrVKmTWO3qdwYzw6NEDnji1u/yV8YDNxheMch9L6W7qj1s6Vwj/tTD94IkHiQEF6c+vE5hH8YMU7HAB6EPUQrix1k2/Ns+cy3gRGDbNad+jNX3UAZS93c349O8A1x1HnFZSC7LuDLPS6Bc3qJhZny85Zt3T4G0VMut6mvuHFl/tBcO1bdzhCfdY6DOgP5vSPgaxibKeNoyp0CIi357yU/T9JFWubyqOtZlDFH3jxZ301rI8ljwv83/pqyCLaIHld4LirEzclGCafAy724BegcKXqprfaoZt/zMxuxolYXZl01H9ldMvDiTCGgmIgNUwEz5k3qnBn7/UuPnOIEyKVwlMwT9A8o6S0iHp5Beiy4svFdZYQpF6lLc4z8j4n8tvzssoL3il0Qc/V3rek0MVwFiuxxkoo16yzl1Iyp+pCkS2qKYBXHAwrRWOtVlcgy9s1I5OZCqofYLzjvWb8YUJk96gW07+518wRRA7HSesMw5ncV+JPzMGL0f4FcjKyqYC3AaJ9kQBnZtfOdtN1ydTzUib7PFTyyDREOap5F8fdZBbjds5yuMQq0cKs9dWIutnjbiKFVelWqSlwDKoQW+Pfn1nBar00d0WhdjPtyK952cFituMmzkMRRZSZzrQpAbLN197iZwezHOHJjyjoUnnH0Tx+N/WbbwYvdnjWmzFHFtubLi6vP5eWKw4dJHzKu669P3hGpoq96cof0EDtJ2hwU0zoeq080Tk6FQESz68Ut0gIdAPfsetUXcGYacZd4Osu+3GCUaqIx+1xKzPcXTAodwfF5W2FYSSJJUUgteAVufUqmHnlvcrgWqxHq4BOnVceg0RyDGlc30NMOKkCPS3HfabijUelEeQbDaLA4uWUFE2Bw4EVjUnorW01+qjEr4njtQ8LWFpLNOpAatgeUFoCxF9ac3ePgsCB6XoDZsYBY+Cvgskw9/LZWRaC0Ws3v8iXYU6ixy78c0hT/Qtl4OPwf6l7Z8AR7NeZXv2DufVtwAWqxRuvGsCqKgETgIsQy3gseQnu7kai5z238/b4RRwqTghyBF7/lffhZDv1sdJdsmHvvl6NHWoVd8G/osmoOwfV+0bbPY09YfWoKCSsxSyTAQCfP4xPT0Cm5m+r3xHIlrs5GZ4kuDURpxDeE5C8ABpaLLXs1qOFP1fioTeq0mMfiIdDBvrJK3olQ3g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oE2le49RxxOEnVgMqu+7zzBtn2SvkTpNg8kx8irOo8QenRTh1nZp2izm73NakHvYx/u4RKkcUQplp00K0FXjyrj0dAuZQiW8BnM8apUaRg9ZBcEPrrNIvIYbpAfG5NZSwG6XTddTiU85ZKvoggjnm14NUB4/5QhXcl9l9TpGRbsA5sg8o7SlVYjqHlZQm1oAgEOhTmbKIPAEZyqH8KzuPXz4AE3/SVdLTWQSnIRxZ+GVD/7R2jM0K85ZO7NeRWvpPgB7xGg6lIeeqrSO4vWY/TIgeOnjhPCL8WPGh56v1rofbnhCgWlNYIje3Dux/pnJQw4wTksH/WWXMDmxZJysMcM4n1thTIPqkEIWJlQa0O5h8oYTek12PCmJXlcYbg88dg9aIk4wE3tCKEQaYn3wdBE8+aigUdrXdfldnku93vIkIdT31/fsKt1EBcxCLoGCtKqS1nt4xz8iIfIrjL6XUr9zg57I/j7nMN/cfVaIk12bMcEHR/BTt9RhMEUFzOnZ1gDsarM0bzYim/mCI0lvs4e2pLIIx2tEd4SRClXktM/z8Gl8GtL6pCiACBSL1hqfNvZaQ7Etw/S6diIWMXgHOU+SgUnrT9Dd+xSCNWoeAGTDkALkmLvsBeFjP4mrTFCqUQ6a0VBRQ88zgTiak3XTrIRJBMjiFXPrfrO6dUt5lt69rNmutZayNQuKaw55NqhKieXO+4aKRgTd/qoJaTslrk68MLqzb02V+Z5wmD4EptCA9Wx0nDy024eV8doJyombUAtbsi/LD+6Kl+q/KEaNuZtwg+suE1qjc3gB2vsicW2ney9gYk5GBIeGpE5HWhV7Ub7IZQLsZgAiAcIdfPsbQL8D5KVJ9YGlhfoWIcuW7eT9cc9UOUiw80x0fC6POFNeCTe9Aq5/AvErhyfDh/n6gkEhhP5xva97x8GGbWx5BqIqlbEvUJ7u/GiwLKFr8AI3R3lH4WFY1Nuq+62Ym08OFqBCpsMomxZTt3plfGQQa/EDBQQC0ZyHbgYuUAaWP30gNLp28LlYOxYM6LBncQr10UK3Nwi/MW/coUc64fLmsYddys4la3p6I42/h0Zbwn0978ZLNV0QizmGjBsJ56KASp9YGTK9wYvQvRxDW/6UgbVj2tyrq+tp6bsop8sYVn9rp3EzIqwjEYWr6d4YPv51PEwso7OU6dLCB9sxsidN6Ect6CP6EFCZIiM2H5/ZdoorYENYyJJluoxG1QlF7VXRnmJb0q98t5pDz2tXUSFdG5koKCSBmi1AO/LXTUCxPrQq87+5k6ylBExTIzFF++RVOm+FB58v7GOaihuSXKaFhoeKKO6jY7eR99lD9w+UZot/Sm+GKV8GTdZiwFbjKwdNnxPUU+r+8mqdrneobrI9tvq9Gr9AtUlPMT7aUTinBGYF+H1xnpP/x1pxqMmvVX7h6erAMloXoajS4Z5xBOlcPf3dsb+GJhhHKL1YchsEqthiVUpOGcOHXUoAQOwsejVyWgpCxBPuF6AyW8xJh6tkOGZpShNZ5RkNpaASNVL4PcWoxWtQRFUrPJwf8EgfTGGpXGgUY0BFoCxyvp/1iWGLn4DBPEzKNEPtu6Ls6kQ2m8I+cv/EFKJHnsTGePEQYcRTnU+9OIS4J0fEDArNwi7J/YU= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: cee9efcb-8ad3-4fac-8be0-08dcb4e77bbe X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2024 00:42:28.7782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yIC2uXeRPM8qXThYCPciLJ09ZjdHZKmoQrhV7/Ma/ncWz6ZTQFUYHxykgSxz1JXUT6/hXHFYp4cCVsbccjHKfSA0LWk5CG+569hWZX7DTZaI/LadhPMYZ9n/l6QPpKd5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9302 Message-ID-Hash: ZFBG5AMJI637RJIEGQ64SLBDQ2VEZVA2 X-Message-ID-Hash: ZFBG5AMJI637RJIEGQ64SLBDQ2VEZVA2 X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We can use snd_pcm_is_playback/capture(). Let's use it. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/wl1273.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/wl1273.c b/sound/soc/codecs/wl1273.c index 737ca82cf9764..2ea7264a18d43 100644 --- a/sound/soc/codecs/wl1273.c +++ b/sound/soc/codecs/wl1273.c @@ -298,13 +298,13 @@ static int wl1273_startup(struct snd_pcm_substream *substream, SNDRV_PCM_HW_PARAM_CHANNELS, 1); break; case WL1273_MODE_FM_RX: - if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + if (snd_pcm_is_playback(substream)) { pr_err("Cannot play in RX mode.\n"); return -EINVAL; } break; case WL1273_MODE_FM_TX: - if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { + if (snd_pcm_is_capture(substream)) { pr_err("Cannot capture in TX mode.\n"); return -EINVAL; } @@ -348,13 +348,13 @@ static int wl1273_hw_params(struct snd_pcm_substream *substream, } if (wl1273->mode == WL1273_MODE_FM_TX && - substream->stream == SNDRV_PCM_STREAM_CAPTURE) { + snd_pcm_is_capture(substream)) { pr_err("Only playback supported with TX.\n"); return -EINVAL; } if (wl1273->mode == WL1273_MODE_FM_RX && - substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { + snd_pcm_is_playback(substream)) { pr_err("Only capture supported with RX.\n"); return -EINVAL; }