From patchwork Mon May 15 08:02:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 104373 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1430449qge; Mon, 15 May 2017 01:04:07 -0700 (PDT) X-Received: by 10.223.139.25 with SMTP id n25mr3098734wra.17.1494835447841; Mon, 15 May 2017 01:04:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494835447; cv=none; d=google.com; s=arc-20160816; b=xzPG4oPVvZrLQ1BdVQURtOioJAUQV5oQLhB/ARBuLAdEJ9mXjI1ighfCEzlY477RqO ixD8bXP+XJCpup6vT/tuI+H1NR33IBg9UxrCIUaPO9BKgtefsjLjcno94k1vgUQZ9DvS j6O8fb6z/AtZVaOoG7ofSZeQk2tXpGH4c/1mL3FzNjGXEf8q8r9Ul3BNrbI54Su6Cn2q UIJvsW+V+qd0RC6p7MIHO/7PIxJT7moM/x5OMuprK7D9eoAg1nIkaVLyXql29SS546+H W6VyHNUDoQGX1wO62L+i0E1C/2zg/K5MkcypIWEnqtO60Hx7/K7AZWVyuvRzKh6/PkcM uwRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=yEHamoThBNPX4mrucGGsq1QYKTHbzqPNfEBgJeL9KHo=; b=YLJnSRCz9oiiu/NJ5X2QaztPZcKn1w0p4SWsquJCrDJfvBkoLgTgAsLYgIcfsA7d+n nqoOlT6OgtDmd7rI7UKjb8SZMiuJ5T1GRkCfIJemY2HXvA/6mtxTAETSqFN5IdbR4jyn Rvoz9k6SikuPhgiRJtIbC2IpHFIIyTpdgdHJD4xP3bbEE9qyFOWrfuPQNfbA93zkJFvI 19i9kjAz8K5VcWRXAYoWx5CHhE9jA3FQ/E8uzGjReCUAteA1m6odMUriSN/BIMWS3hCE yqTVIShnpGJ4YcPVdM0NVZ7N+hy4MORWFrHQhFu8jMuOa9v92ytcR0TVks6QXfkFHOm5 mBcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id u64si11643819wmg.60.2017.05.15.01.04.07; Mon, 15 May 2017 01:04:07 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 48441267335; Mon, 15 May 2017 10:03:09 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 289652672B1; Mon, 15 May 2017 10:03:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 18BA42672B4 for ; Mon, 15 May 2017 10:02:43 +0200 (CEST) Received: from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dAAxh-0001iW-SS; Mon, 15 May 2017 08:02:40 +0000 Received: from broonie by finisterre with local (Exim 4.89) (envelope-from ) id 1dAAxe-0002Ps-B4; Mon, 15 May 2017 17:02:34 +0900 From: Mark Brown To: Takashi Sakamoto In-Reply-To: <20170502133303.19622-4-o-takashi@sakamocchi.jp> Message-Id: Date: Mon, 15 May 2017 17:02:34 +0900 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org, John Stultz , Andy Green Subject: [alsa-devel] Applied "ASoC: hisilicon: localize functions without external linkage" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: hisilicon: localize functions without external linkage has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 2a54e845f6e5069666e1749bd952abdc0413910d Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Tue, 2 May 2017 22:33:02 +0900 Subject: [PATCH] ASoC: hisilicon: localize functions without external linkage A driver for hi6210 sound interface on hi6220 boards includes some functions which has no external linkage. These functions should have static qualifier. This commit adds the qualifier to localize the functions. This issue is detected by sparse: hi6210-i2s.c:100:5: warning: symbol 'hi6210_i2s_startup' was not declared. Should it be static? hi6210-i2s.c:178:6: warning: symbol 'hi6210_i2s_shutdown' was not declared. Should it be static? hi6210-i2s.c:527:27: warning: symbol 'hi6210_i2s_dai_init' was not declared. Should it be static? Signed-off-by: Takashi Sakamoto Signed-off-by: Mark Brown --- sound/soc/hisilicon/hi6210-i2s.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.11.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/hisilicon/hi6210-i2s.c b/sound/soc/hisilicon/hi6210-i2s.c index 45163e5202f5..b193d3beb253 100644 --- a/sound/soc/hisilicon/hi6210-i2s.c +++ b/sound/soc/hisilicon/hi6210-i2s.c @@ -97,8 +97,8 @@ static inline u32 hi6210_read_reg(struct hi6210_i2s *i2s, int reg) return readl(i2s->base + reg); } -int hi6210_i2s_startup(struct snd_pcm_substream *substream, - struct snd_soc_dai *cpu_dai) +static int hi6210_i2s_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *cpu_dai) { struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev); int ret, n; @@ -175,8 +175,9 @@ int hi6210_i2s_startup(struct snd_pcm_substream *substream, return 0; } -void hi6210_i2s_shutdown(struct snd_pcm_substream *substream, - struct snd_soc_dai *cpu_dai) + +static void hi6210_i2s_shutdown(struct snd_pcm_substream *substream, + struct snd_soc_dai *cpu_dai) { struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev); int n; @@ -524,7 +525,7 @@ static struct snd_soc_dai_ops hi6210_i2s_dai_ops = { .shutdown = hi6210_i2s_shutdown, }; -struct snd_soc_dai_driver hi6210_i2s_dai_init = { +static const struct snd_soc_dai_driver hi6210_i2s_dai_init = { .probe = hi6210_i2s_dai_probe, .playback = { .channels_min = 2,