From patchwork Mon Nov 27 18:53:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119778 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp2103893edl; Mon, 27 Nov 2017 10:58:00 -0800 (PST) X-Google-Smtp-Source: AGs4zMZlh0PfRhMnEuNWG/JW9nto4dsZLu3pt0qd1B5DYdHsdIky2WzsbY3rLyIKqizfwOVDKPLb X-Received: by 10.223.139.67 with SMTP id v3mr34368371wra.70.1511809080648; Mon, 27 Nov 2017 10:58:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511809080; cv=none; d=google.com; s=arc-20160816; b=vxqWJyzcw5Mcduv3QyrgJLpBMkHI1Z6GM+ytiIuA7gB/ZzpwpELUHi5+fHLIY8sZM+ 3Zn2mH5RHnkbmNRXPK/FaowYIixNxgtUWXBi6rFM3LguLSQVI35Dj343Bd0Xz5PPGFM4 bxg3bNWHuoBJ2dwS5/pju/shb11G+mft7PdrRort7Z3v5EqwxB5PDz7T9FyYjIO2TTUR 1fIjq5XFriaEo6UW71TKT3tgR3Jgk12hz3DmnsGD9S73iHSYkTJvo00sj6kG1NrJUXYj 4Ijp+BD/CjsEC376vmi3wS87HzoMI+THkMBUlSk9fWn8tY6bqX8tFWUv828QBF9WSJle 4a0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=tQtq3Y/a7aBcybn0KtVQ1ymGrGD4KtJbjt8TDI18HZQ=; b=GIomrcoyUDerOjEFB08OboB6W4iDkGcv80CTRacTk4KwGaLu3xDdPhkj08iPXtBf/l shDMrb+YUOmo/7MGijbFaNvztr63drUlefJeR1K4GRfZ2U4fVoEGDI9jVx6hjBHmzj4d TC+0BYmQSL+AS+FwetGVaf8wL42ho8wrfMIpQgv/53u5NihSucsIN7rdC8sr3KO2gDkH fOiLTOsECoGjT438hYOdmb3p+F9sZvaCX+jqmAnVzYRMnHEOtKY1mwtSHM1hX6cJdwNv 4i3hrcdRaSVyhewm2altW8ZjmLYT9uHUAKb0X5wBYxi6CBsLKXtATBNCpP6G8oCUv2XJ +g8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WpNXpBb6; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id t80si21986895wrc.307.2017.11.27.10.58.00; Mon, 27 Nov 2017 10:58:00 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=WpNXpBb6; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 77F5B2676D8; Mon, 27 Nov 2017 19:54:32 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0CA6D2676D1; Mon, 27 Nov 2017 19:54:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DF0F12675A4 for ; Mon, 27 Nov 2017 19:53:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=7oNWu0+5wwquPsSFrZz+Vw9hqdsD6U2LiBRMc3dT1Zw=; b=WpNXpBb6EPen /FMbubDNtZnIDU3d4aSb2FxIAD9Sgv5XDe+Ms1s0V5/5uxEHrJSrmAdvnCKFPgdbwhsq5Xtz4AXR1 E5NRiOsM38YN1uKVHjfpZKbJEA1fxNt4p47pP6+eVb1YTLVzFIHgAom6EgAbqUDsVwdecJnomTMK1 1c3vg=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eJOX0-00073B-EI; Mon, 27 Nov 2017 18:53:26 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eJOX0-0007I4-1i; Mon, 27 Nov 2017 18:53:26 +0000 From: Mark Brown To: Benson Leung In-Reply-To: Message-Id: Date: Mon, 27 Nov 2017 18:53:26 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 8ee649283b1e542aedba007f6c828d6767c48e0d Mon Sep 17 00:00:00 2001 From: Benson Leung Date: Wed, 22 Nov 2017 12:56:39 -0800 Subject: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support. For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung Signed-off-by: Mark Brown --- sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c index e7672831bc49..38512f0d1a73 100644 --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c @@ -195,7 +195,7 @@ static int kabylake_rt5663_codec_init(struct snd_soc_pcm_runtime *rtd) } jack = &ctx->kabylake_headset; - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP); snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);