From patchwork Thu Nov 30 12:32:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 120169 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp606862qgn; Thu, 30 Nov 2017 04:33:19 -0800 (PST) X-Google-Smtp-Source: AGs4zMYy4qrbg+4vdrfe/voxpgjG0JEEmL+M8KHjqnLarrw9RBML+JFCooM8EHk7RkWEcEBxR3vL X-Received: by 10.28.203.197 with SMTP id b188mr1883519wmg.105.1512045198963; Thu, 30 Nov 2017 04:33:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512045198; cv=none; d=google.com; s=arc-20160816; b=w03L+Q3+f1DuhWPpMtbxmWyQqeYTcVbXJXgFHDo8s/DtF1nOMeUz1K01nSSzvfg6A+ HkWHPkxk+HBoUKQ/GcGbqUtx9mU02rcu4h3xb/HnwUYltmPDA3ya3R0EoF6CRj2Bw0is SUo6M+1bQWQlEoUA1NXuut+gs8+j8TfwtzA4gNZO5LztmzttoJwIamRJld3joVpgY7ik LgG2P4OcMmDTM/mn75uHtVFxlSxynaj4howShGtoHxuKAfVMQG8AxyNZ4WUnMbsdPAtC NW1KH5TjmYhFrOgCsV2F4R/Tdunb/EljyG2Lxd77kaxtgBT5PfBDjMclHVER1UXZ8wHB AJsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=ybL7hCsBCSppqvPdtqCbD55t1/oi6bY1w1SLRnxVw8M=; b=RZ5v6LJS077Z0hsZI0p8hMdOULkAVk6TCgoRKBRwBNRIMGCQQY1HlOa67FbmRANjJZ MZh+sdjgj+21kyKvncmMYasfwOneTYw6Awq7zWf39dzQ8eTGn2YYv3/OY/MiAy/CD6Gm T8flaSHkER2u2aYM1USk5ER/H6wa7UC0D/zF9lFtBGJASgNSuVQitmjZ1+5tSyCWRU7m CE1XMQ1vcj/7J5PJ9qtJJ2XSN2P2OkebxqGDy3u4CxkFwbCSdVh1HUY20+J2Bcvk/pX0 Ht4vQ4SeVG4vXrseU35mgLpEyV6n8s+rMlPo2NDHB0//TblAkOqX3XhHri8EBalOx/Ft eABQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=O07TO+ef; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id o85si3200572wme.260.2017.11.30.04.33.18; Thu, 30 Nov 2017 04:33:18 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=O07TO+ef; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 56F652679D2; Thu, 30 Nov 2017 13:33:08 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C06E52679DA; Thu, 30 Nov 2017 13:33:07 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id A25DD26698E for ; Thu, 30 Nov 2017 13:33:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=YDb4WsMtXmFsJElgOCxao1f2ezuf7rvydA6ww8LJCvg=; b=O07TO+efweSB M1B78lPdNDPS/Cf6aixxpw+oQRJ0aFOcPNoD30n9aCWw38gJClr74w+MKqB1U7Z2nTc07ljFnn93j tX80VTFXwWuOgY3hcpQ3elh16VKOpFduv/FklgCdV/CXgCcNh3YvOGjRReVhxe8Lx7tLrJYcQ4gYm z6vPA=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eKO1S-0003Fz-RD; Thu, 30 Nov 2017 12:32:58 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eKO1S-0000US-Eb; Thu, 30 Nov 2017 12:32:58 +0000 From: Mark Brown To: Andrew F. Davis In-Reply-To: <20171129213300.20021-3-afd@ti.com> Message-Id: Date: Thu, 30 Nov 2017 12:32:58 +0000 Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Tony Lindgren , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Mark Brown , =?utf-8?q?Beno=C3=AEt_Cousson?= , "Andrew F . Davis" Subject: [alsa-devel] Applied "ASoC: tlv320aic31xx: Change aic31xx_power_off return type to void" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: tlv320aic31xx: Change aic31xx_power_off return type to void has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From c7734e8e7eddf065c15e865b8de4224b01f03409 Mon Sep 17 00:00:00 2001 From: "Andrew F. Davis" Date: Wed, 29 Nov 2017 15:32:43 -0600 Subject: [PATCH] ASoC: tlv320aic31xx: Change aic31xx_power_off return type to void The return value is not checked, and even if it was there is nothing we could do about it and messages are already printed. Signed-off-by: Andrew F. Davis Signed-off-by: Mark Brown --- sound/soc/codecs/tlv320aic31xx.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c index b98d9b1f216f..0563a49cc5e4 100644 --- a/sound/soc/codecs/tlv320aic31xx.c +++ b/sound/soc/codecs/tlv320aic31xx.c @@ -1081,16 +1081,13 @@ static int aic31xx_power_on(struct snd_soc_codec *codec) return 0; } -static int aic31xx_power_off(struct snd_soc_codec *codec) +static void aic31xx_power_off(struct snd_soc_codec *codec) { struct aic31xx_priv *aic31xx = snd_soc_codec_get_drvdata(codec); - int ret = 0; regcache_cache_only(aic31xx->regmap, true); - ret = regulator_bulk_disable(ARRAY_SIZE(aic31xx->supplies), - aic31xx->supplies); - - return ret; + regulator_bulk_disable(ARRAY_SIZE(aic31xx->supplies), + aic31xx->supplies); } static int aic31xx_set_bias_level(struct snd_soc_codec *codec,