From patchwork Mon Jun 4 13:56:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 137632 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1545782lji; Mon, 4 Jun 2018 06:57:00 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIDCjQIdk8xRHXi9Lr7YJAKLsuvyXTWD8APxXcbyCZRdY/by5MBzqTj98HvpKmtKOojHPw9 X-Received: by 2002:adf:9125:: with SMTP id j34-v6mr17385706wrj.156.1528120620390; Mon, 04 Jun 2018 06:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528120620; cv=none; d=google.com; s=arc-20160816; b=DafI5QfcVtoFlqZq0dGKonpkot52oYB1H+NOY5v2lF4j3rgnl7frgU90V+x+s8/lUI FXltvIU3idsTYWoWF4qIiz/pZi9rqflEFeG+Qw4Q37UOne2S6em3DS9R9s3stTsXXCq9 LTeWabvqgJB7/njsn00mOrWV9H1SId3GD2g3rcNzn8WMqlSxnLyEPEBnuAlUw22lZo3S 0i9tnAzz1n75ylPJepRXAn6jKvdrs/hTE3ikfZ1+BKsB+AhLZiBR+Y4DvWZP6cJO9PQa yhaMdWMHUIBEUULKFCMlPyDVrA1kpEGQuIW0vJ2jWfGI1f0Uvy9EhtlBJwtjcwO+JE1H PxbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=4JuMrOohLgxq71Hx6GbO9JRjXvlNC9YTTVxo6HflbJw=; b=KYzGSqg/6dNGaCW3b1Kg7r5+3zxbC0YkrKm9AaXeqgpq365+XZmSblJfanV3QAjfEY PRUFFjl5zzefCvg6E7Mhf8JRIvBWiBUCqC6w7+/nNPJ6rcb3ph80AR52haSR5aPCUrrk NGZrnHHni5YQfRfgCNZCywIhfI75X4YxVJLQxVGH8kiKUG2VAsp8hoQxHfOGY5ZX7XEg ev2xU1MHb/QCvxL2QeWX9UNMbj0JoEiywDNbonE0xsYyKMqS7zJLxhO3g9CRk1niPhRq Fu8xGAr+vfzjcBg2KLlx2jabVrQHQnxRGJmoIo+8FrSSxulQIAGs2L4kZ5IkdZJJLOBQ lQkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hiP/YFWq; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id b131-v6si177412wmc.223.2018.06.04.06.57.00; Mon, 04 Jun 2018 06:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=hiP/YFWq; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1C736267ACB; Mon, 4 Jun 2018 15:56:59 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 91762267B11; Mon, 4 Jun 2018 15:56:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 504EF267A6C for ; Mon, 4 Jun 2018 15:56:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=7FVHT38dYk80OV7WwIMzZdzjSsGPtE/AWChApEnYYy8=; b=hiP/YFWqf06/ /fSZPYNZf+PU+anWxvO3a2es53H77FpSWHNmMEL5xkYLMRdOov7dQC1X8ONL4KkKduv4WbZVsF9xp gF9XMuoX38sP2EPDCZ3M8gYPFa9woC1Kw7lGFoY/D5nk+7x8fWs6tEvH7GvoTkRkbLjKeXcN/OCH6 h3ThE=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fPpyX-0005qN-8e; Mon, 04 Jun 2018 13:56:45 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fPpyW-0004Ko-In; Mon, 04 Jun 2018 14:56:44 +0100 From: Mark Brown To: Srinivas Kandagatla In-Reply-To: <20180604111326.15708-1-srinivas.kandagatla@linaro.org> Message-Id: Date: Mon, 04 Jun 2018 14:56:44 +0100 Cc: rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, tiwai@suse.com, stable@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] Applied "ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ff2faf1289c1f81b5b26b9451dd1c2006aac8db8 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Mon, 4 Jun 2018 12:13:26 +0100 Subject: [PATCH] ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it dapm_kcontrol_data is freed as part of dapm_kcontrol_free(), leaving the paths pointer dangling in the list. This leads to system crash when we try to unload and reload sound card. I hit this bug during ADSP crash/reboot test case on Dragon board DB410c. Without this patch, on SLAB Poisoning enabled build, kernel crashes with "BUG kmalloc-128 (Tainted: G W ): Poison overwritten" Signed-off-by: Srinivas Kandagatla Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- sound/soc/soc-dapm.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 1e9a36389667..36a39ba30226 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -433,6 +433,8 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget, static void dapm_kcontrol_free(struct snd_kcontrol *kctl) { struct dapm_kcontrol_data *data = snd_kcontrol_chip(kctl); + + list_del(&data->paths); kfree(data->wlist); kfree(data); }