Message ID | 162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk |
---|---|
Headers | show |
Series | netfs, afs, ceph: Support folios, at least partially | expand |
Matthew Wilcox <willy@infradead.org> wrote: > > +static inline struct inode *folio_inode(struct folio *folio) > > +{ > > + return folio_file_mapping(folio)->host; > > You're contradicting yourself here. If you're allowed to call this > function for swap cache pages, then the documentation needs to change. > If you're not, then we can just use folio->mapping->host. Um. I don't know. I'll do the latter, then, for now. David
On Tue, Aug 24, 2021 at 02:24:47PM +0100, David Howells wrote: > + ret = afs_store_data(vnode, &iter, > + (loff_t)page->index * PAGE_SIZE + f, true); You probably want to use page_offset() here: ret = afs_store_data(vnode, &iter, page_offset(page) + f, true);