| Message ID | 162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk |
|---|---|
| Headers | show |
| Series | netfs, afs, ceph: Support folios, at least partially | expand |
Matthew Wilcox <willy@infradead.org> wrote: > > +static inline struct inode *folio_inode(struct folio *folio) > > +{ > > + return folio_file_mapping(folio)->host; > > You're contradicting yourself here. If you're allowed to call this > function for swap cache pages, then the documentation needs to change. > If you're not, then we can just use folio->mapping->host. Um. I don't know. I'll do the latter, then, for now. David
On Tue, Aug 24, 2021 at 02:24:47PM +0100, David Howells wrote: > + ret = afs_store_data(vnode, &iter, > + (loff_t)page->index * PAGE_SIZE + f, true); You probably want to use page_offset() here: ret = afs_store_data(vnode, &iter, page_offset(page) + f, true);
Here's a set of patches to convert netfs and afs to use folios and to provide sufficient conversion for ceph that it can continue to use the netfs library. Jeff Layton is working on fully converting ceph. This based on top of part of Matthew Wilcox's folio changes[1] David Link: https://git.infradead.org/users/willy/pagecache.git/shortlog/refs/heads/for-next [1] Link: https://lore.kernel.org/r/2408234.1628687271@warthog.procyon.org.uk/ # v0 --- David Howells (6): afs: Fix afs_launder_page() to set correct start file position folio: Add a function to change the private data attached to a folio folio: Add a function to get the host inode for a folio afs: Sort out symlink reading netfs, afs, ceph: Use folios afs: Use folios in directory handling fs/afs/dir.c | 229 +++++++++++-------------- fs/afs/dir_edit.c | 154 ++++++++--------- fs/afs/file.c | 82 +++++---- fs/afs/inode.c | 6 +- fs/afs/internal.h | 49 +++--- fs/afs/write.c | 333 ++++++++++++++++++------------------- fs/ceph/addr.c | 80 ++++----- fs/netfs/read_helper.c | 165 +++++++++--------- include/linux/netfs.h | 12 +- include/linux/pagemap.h | 33 ++++ include/trace/events/afs.h | 21 +-- mm/page-writeback.c | 2 +- 12 files changed, 584 insertions(+), 582 deletions(-)